Date: Fri, 29 Jul 2005 22:43:11 +0800 From: Yen-Ming Lee <leeym@FreeBSD.org> To: Edwin Groothuis <edwin@mavetju.org> Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/84263: add 'test' target if it's a perl module Message-ID: <20050729144311.GA91680@utopia.leeym.com> In-Reply-To: <20050729034344.GB1162@k7.mavetju> References: <200507290250.j6T2oOA7010777@freefall.freebsd.org> <20050729034344.GB1162@k7.mavetju>
next in thread | previous in thread | raw e-mail | index | archive | help
--MGYHOYXEY6WxJCY8 Content-Type: text/plain; charset=big5 Content-Disposition: inline On Fri, Jul 29, 2005 at 01:43:44PM +1000, Edwin Groothuis wrote: > On Fri, Jul 29, 2005 at 02:50:24AM +0000, Yen-Ming Lee wrote: > > It will slow down the packages building process. I think it'll be better > > if we wrap it with ENABLE_PERL_MODULE_TEST or something like that, and keep > > it disabled by default. > > How about: > > .if defined(PERL_CONFIGURE) && !defined(PACKAGE_BUILDING) > .endif > > Edwin > > -- > Edwin Groothuis | Personal website: http://www.mavetju.org > edwin@mavetju.org | Weblog: http://weblog.barnet.com.au/edwin/ Hmm, ahze@ told me that some modules will not pass the tests in some case. For example, x11-toolkits/p5-Tk will only pass the test when X11 is running. I guess we need to use a knob to wrap it and only enable it when users want it explicitly. -- Yen-Ming Lee [utf7:+Z05fZWYO] | KeyID:0x5EB52E51 | Taipei, Taiwan --MGYHOYXEY6WxJCY8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iQCVAwUBQupAf8nMx0NetS5RAQIieAQAxvmtrzZiaxKqoytI6ln7FO7ECVFdyb3l KloH+9DJk7K+xamhJOQZ44Qi0T+7icUd9UBb6IUfqWynzeHVy61EqDnzKwo7uvDp 7GLxq6SOaRxMgpuff13iiQkKNjNPqNumBKGoCkUEh5j3Ih3VOgtyGTVUGU1CblRG lAQaklorrVs= =oboO -----END PGP SIGNATURE----- --MGYHOYXEY6WxJCY8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050729144311.GA91680>