From owner-svn-ports-head@freebsd.org Thu Nov 1 07:07:03 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AE36210E14AE; Thu, 1 Nov 2018 07:07:03 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 686446D1DD; Thu, 1 Nov 2018 07:07:03 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 4B9EB1AF85; Thu, 1 Nov 2018 07:07:03 +0000 (UTC) Date: Thu, 1 Nov 2018 07:07:03 +0000 From: Alexey Dokuchaev To: "Jason E. Hale" Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r483626 - head/audio/taglib Message-ID: <20181101070703.GA45853@FreeBSD.org> References: <201810312326.w9VNQdgV020234@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201810312326.w9VNQdgV020234@repo.freebsd.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 07:07:03 -0000 On Wed, Oct 31, 2018 at 11:26:39PM +0000, Jason E. Hale wrote: > New Revision: 483626 > URL: https://svnweb.freebsd.org/changeset/ports/483626 > > Log: > audio/taglib: Fix build on powerpc64 > > PR: 232812 Looks like commit message is not accurate. From the PR, he says that c++11-lang is needed to fix "linking of devel/kf5-kfilemetadata on GCC architectures", not the build of the port itself. Given the lack of context in those PRs by Piotr Kubaj I'd suggest we give a closer look when dealing with them; at the very least, commit logs should adequately describe the problem being fixed. ./danfe