From owner-freebsd-wireless@FreeBSD.ORG Wed Nov 30 08:53:43 2011 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DB5991065672; Wed, 30 Nov 2011 08:53:43 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 7A8278FC08; Wed, 30 Nov 2011 08:53:43 +0000 (UTC) Received: by vcbfk1 with SMTP id fk1so296857vcb.13 for ; Wed, 30 Nov 2011 00:53:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=JZ5wqcRoykR/qY4cc3id0XBEGh8leyTROnTbIHnGIZo=; b=TEe0y8XlFXGLr6gaBLd/lVmOYXJF0dgdLUPjQFaFbf+gsman/V9Ql7P1w5s8RsWD9M tAoq6vWDjYZPviWNIfluLAULSpOb3wzgwlgP8/0CZwPCUBbmA8sIWZu1RmW8AP0MZu+S kFTKLnXCFFQ/LG31FnlvGYu55sgOATRp6ZMCM= MIME-Version: 1.0 Received: by 10.52.33.69 with SMTP id p5mr1219031vdi.78.1322643222776; Wed, 30 Nov 2011 00:53:42 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.52.186.74 with HTTP; Wed, 30 Nov 2011 00:53:42 -0800 (PST) In-Reply-To: References: Date: Wed, 30 Nov 2011 16:53:42 +0800 X-Google-Sender-Auth: HodXURadoJPI-Bc7eLEuKUPiK0Y Message-ID: From: Adrian Chadd To: Bernhard Schmidt Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-wireless@freebsd.org, Ninad Adi Subject: Re: Why does iwn driver in FreeBSD is coded in just one file. X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2011 08:53:43 -0000 On 30 November 2011 16:36, Bernhard Schmidt wrote: > On Tue, Nov 29, 2011 at 20:52, Ninad Adi wrote: >> Hereby, I officially =A0propose the splitting up of iwn driver code as >> it is growing and will continue growing as >> rate scaling improvements plus the P2P mode support would come into pict= ure. > > iwn(4) is imported (mostly, sans 11n support) unmodified from OpenBSD, > up till now there isn't a single valid reason to split up any of the > code. Heck, I've done my best to keep the code diff(1)able against the > original code. That sounds logical. Unless we can convince the openbsd iwn maintainer to split the driver up.. ? > If *you* gonna provide additional features to iwn(4) I might > reconsider that decision, but I want to see some code first. Btw, any > ratectl related stuff should go to net80211(4) not to the drivers, > same for P2P, we have not a single line of code to support that > currently. If you're going to hack on p2p support, can I suggest we prototype it using the ath(4) code? Since I'm the one looking after that, I'm happy to continue splitting the driver up (which i will be doing in a couple weeks) and it'll likely be easier to add/test p2p support there. thanks, Adrian