From owner-svn-src-stable@FreeBSD.ORG Tue Dec 15 23:13:33 2009 Return-Path: Delivered-To: svn-src-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E319E1065679 for ; Tue, 15 Dec 2009 23:13:33 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 74A668FC12 for ; Tue, 15 Dec 2009 23:13:33 +0000 (UTC) Received: (qmail 9462 invoked by uid 399); 15 Dec 2009 23:13:32 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 15 Dec 2009 23:13:32 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4B28181B.5070503@FreeBSD.org> Date: Tue, 15 Dec 2009 15:13:31 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Thunderbird 2.0.0.23 (X11/20091206) MIME-Version: 1.0 To: Hiroki Sato References: <200912070625.nB76PJli043796@svn.freebsd.org> In-Reply-To: <200912070625.nB76PJli043796@svn.freebsd.org> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r200205 - stable/8/etc X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2009 23:13:34 -0000 Hiroki Sato wrote: > Author: hrs > Date: Mon Dec 7 06:25:19 2009 > New Revision: 200205 > URL: http://svn.freebsd.org/changeset/base/200205 > > Log: > MFC: > > r197144: > - Add an extension of set_rcvar(), a new function set_rcvar_obsolete(), > and $desc. > > The set_rcvar_obsolete() is to mark a variable as obsolete and define > the new one. More specifically, a warning is displayed when > a variable is removed or changed in the source tree and the user > still defines the old one. > @@ -588,7 +616,7 @@ run_rc_command() > esac > > eval _override_command=\$${name}_program > - command=${_override_command:-$command} > + command=${command:-${_override_command}} > > _keywords="start stop restart rcvar $extra_commands" > rc_pid= Hiroki, You apparently merged your change from r197144 without applying my fix for this problem above from r198162, which broke this feature in 8-stable. See http://www.freebsd.org/cgi/query-pr.cgi?pr=141642 In my mind breaking this feature in a -stable branch is a fairly serious error, and adds fuel to my growing discomfort about the changes you've been making in /etc. How do you suggest that we move forward and at the same time lessen the potential for further problems? Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/