From owner-freebsd-geom@FreeBSD.ORG  Thu Dec 30 12:24:32 2004
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9C5F016A4CE; Thu, 30 Dec 2004 12:24:32 +0000 (GMT)
Received: from critter.freebsd.dk (f170.freebsd.dk [212.242.86.170])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id AC1E643D70; Thu, 30 Dec 2004 12:24:31 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id iBUCNtn3040084;
	Thu, 30 Dec 2004 13:23:57 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: Pawel Jakub Dawidek <pjd@freebsd.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Thu, 30 Dec 2004 13:16:50 +0100."
             <20041230121650.GB784@darkness.comp.waw.pl> 
Date: Thu, 30 Dec 2004 13:23:55 +0100
Message-ID: <40083.1104409435@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: Dag-Erling Sm?rgrav <des@des.no>
cc: geom@freebsd.org
Subject: Re: GEOM_VOL panics when audio CD is present 
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Dec 2004 12:24:32 -0000

In message <20041230121650.GB784@darkness.comp.waw.pl>, Pawel Jakub Dawidek wri
tes:
>
>--MfFXiAuoTsnnDAfZ
>Content-Type: text/plain; charset=iso-8859-2
>Content-Disposition: inline
>Content-Transfer-Encoding: quoted-printable
>
>On Wed, Dec 29, 2004 at 05:28:09PM +0100, Pawel Jakub Dawidek wrote:
>+> On Wed, Dec 29, 2004 at 04:53:05PM +0100, Dag-Erling Sm?rgrav wrote:
>+> +> g_vol_ffs_taste() tries to taste audio CDs, triggering a KASSERT in
>+> +> g_io_request() because 65536 is not a valid offset on a medium with
>+> +> 2352-byte sectors.  The exact panic message is "wrong offset 65536 for
>+> +> sectorsize 2352" (sys/geom/geom_io.c lines 250-251).
>+> +>=20
>+> +> None of this code has been touched recently, so I suspect the same bug
>+> +> is present in 5.3, though I haven't had a chance to test it yet.
>+>=20
>+> Those KASSERT()s are hiden under DIAGNOSTIC in RELENG_5.
>+>=20
>+> Anyway, I had simlar problems. I'll prepare a patch to try soon.
>
>Hmm, I'm not sure what is correct way to fix it.

The correct fix is of course to fix the bug in the geom_vol_ffs
class that makes it even try to read things from providers which
have sectorsizes it cannot cope with.

>Maybe we should just remove those KASSERTs?

The KASSERTS are correct and should not be removed.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.