From owner-freebsd-arm@FreeBSD.ORG  Thu Sep  4 16:43:04 2008
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4C7441065675;
	Thu,  4 Sep 2008 16:43:04 +0000 (UTC) (envelope-from sam@freebsd.org)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.freebsd.org (Postfix) with ESMTP id 20CB38FC13;
	Thu,  4 Sep 2008 16:43:04 +0000 (UTC) (envelope-from sam@freebsd.org)
Received: from Macintosh-4.local ([10.0.0.194]) (authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id m84GQ3Nd011461
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 4 Sep 2008 09:26:03 -0700 (PDT) (envelope-from sam@freebsd.org)
Message-ID: <48C00C1A.10503@freebsd.org>
Date: Thu, 04 Sep 2008 09:26:02 -0700
From: Sam Leffler <sam@freebsd.org>
Organization: FreeBSD Project
User-Agent: Thunderbird 2.0.0.16 (Macintosh/20080707)
MIME-Version: 1.0
To: Rafal Jaworowski <raj@semihalf.com>
References: <48BFE533.7010602@semihalf.com>	<20080904200232.a8b556c9.stas@FreeBSD.org>
	<48C0092F.3030308@semihalf.com>
In-Reply-To: <48C0092F.3030308@semihalf.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-DCC-sonic.net-Metrics: ebb.errno.com; whitelist
Cc: freebsd-arm@freebsd.org
Subject: Re: ARM interrupts fixes
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the StrongARM Processor <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Sep 2008 16:43:04 -0000

Rafal Jaworowski wrote:
> Stanislav Sedov wrote:
>> The patch looks goot to me. But what about splitting the whitespace
>> fixes and the meaningful ones when committing to the tree to not
>> pollute the history?
> 
> I can do it, but was under the impression that white space fix-only commits
> were rather frowned upon, isn't it the case any longer?

Senseless churn is frowned upon.  Ya know, the gratuitous knob-polishing
some folks like to do that unintentionally introduce subtle bugs because
the result isn't tested (and often not found until long after).

If you're working in an area and it warrants cleanup then one hopes
you're also testing.  That's fine but as stas requested please commit
the changes separately.

	Sam