From owner-svn-src-all@freebsd.org Wed Dec 30 17:18:34 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0E56CA56831 for ; Wed, 30 Dec 2015 17:18:34 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-wm0-x22c.google.com (mail-wm0-x22c.google.com [IPv6:2a00:1450:400c:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 97B28130C for ; Wed, 30 Dec 2015 17:18:33 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-wm0-x22c.google.com with SMTP id u188so45376226wmu.1 for ; Wed, 30 Dec 2015 09:18:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=CBYO4LPWiVWT1JMw+DCcmXayAchdn7rY1LjjZ3bPQoE=; b=Z5HPilHB9JSOIaR8Eo66YtBrrGzdPuWlbqJvVLC2/6J6FYT3V6drh5K3B4Q0v33xSE AVMol32T1V/7QiqoW3toiCTfwLwDWlNq/b/U+++f5WpRnai29wgFiKih69OmcG6F6B5Y 42WliyxGY+nbbltIWsJZA48HKOmUqLJGu1kOFFm3FQXjom0x4fQZF+atoOPhK6a9BOpx X2rBHyH7t3bNsLOrhHoIwz5NxgvcG6py/ptLf+22z/Vprj/FzqKSGZhr9t87gsyaYnuA ncdqka3+GWuL95XWHrNPEu3Ni4Drao/+ZVtKdlKxorLkr9XZcDWusBHxIREPOwnSK9S3 7vsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=CBYO4LPWiVWT1JMw+DCcmXayAchdn7rY1LjjZ3bPQoE=; b=PsLbIrYiqoKR+6bbArEnRCC6bMGwgvcj7VKEmbKYe8Dyrl0IVEK0WTVebhc4PHUrcU aYhxt2HVhDleuRFt/aqcfnzdMYdyv7MtZYl+1aNSDYdMv1a5+aG7TsTfhPZYPAeSvDqJ HEE/YY6dd+B/haX2xTNECOUKqO1cSNjyRtsJmTN+oyvKVVp5cI772/m5SKSCQeeaD90o V5CrVHkIVb5aMTMzCK44aRO0Jfp+YFEWR2/O63Xhy/C0ONv3++4AnqS7GFlIMJ/qOIQY d/awGU58LeH+J6MclRQg+7qwok+s2NloWD7qZNhMMrHVBia5GpoinrGuDxxjmnFiB/kA phIg== X-Gm-Message-State: ALoCoQmUX65MQKz7VTdPh3uOCGCMed8WBn+T+ITIiXpPoNixumVOiGGn6QZCOP57bJqMMS0YmnM0MYBdDQFHKIldb9kxwyxL8ktUNlY19KFSO5vq6jW/QIw= MIME-Version: 1.0 X-Received: by 10.194.202.163 with SMTP id kj3mr68176181wjc.93.1451495911246; Wed, 30 Dec 2015 09:18:31 -0800 (PST) Received: by 10.194.85.167 with HTTP; Wed, 30 Dec 2015 09:18:31 -0800 (PST) In-Reply-To: <201512271733.tBRHXxgN031823@repo.freebsd.org> References: <201512271733.tBRHXxgN031823@repo.freebsd.org> Date: Wed, 30 Dec 2015 18:18:31 +0100 Message-ID: Subject: Re: svn commit: r292782 - in head: lib/libcrypt lib/libmd sbin/gbde sbin/geom/class/eli sbin/md5 sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/conf sys/crypto/sha2 sys/dev/random sys/geom/bde sys/... From: Oliver Pinter To: Allan Jude Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Dec 2015 17:18:34 -0000 On 12/27/15, Allan Jude wrote: > Author: allanjude > Date: Sun Dec 27 17:33:59 2015 > New Revision: 292782 > URL: https://svnweb.freebsd.org/changeset/base/292782 > > Log: > Replace sys/crypto/sha2/sha2.c with lib/libmd/sha512c.c > > cperciva's libmd implementation is 5-30% faster > > The same was done for SHA256 previously in r263218 > > cperciva's implementation was lacking SHA-384 which I implemented, > validated against OpenSSL and the NIST documentation > > Extend sbin/md5 to create sha384(1) > > Chase dependancies on sys/crypto/sha2/sha2.{c,h} and replace them with > sha512{c.c,.h} > > Reviewed by: cperciva, des, delphij > Approved by: secteam, bapt (mentor) > MFC after: 2 weeks > Sponsored by: ScaleEngine Inc. > Differential Revision: https://reviews.freebsd.org/D3929 > > Added: > head/sys/crypto/sha2/sha384.h (contents, props changed) > head/sys/crypto/sha2/sha512.h > - copied, changed from r292757, head/lib/libmd/sha512.h > head/sys/crypto/sha2/sha512c.c > - copied, changed from r289398, head/lib/libmd/sha512c.c > Deleted: > head/lib/libmd/sha512.h > head/lib/libmd/sha512c.c > head/sys/crypto/sha2/sha2.c > head/sys/crypto/sha2/sha2.h > Modified: > head/lib/libcrypt/Makefile > head/lib/libmd/Makefile > head/lib/libmd/sha512.3 > head/lib/libmd/shadriver.c > head/sbin/gbde/Makefile > head/sbin/gbde/gbde.c > head/sbin/geom/class/eli/Makefile > head/sbin/md5/Makefile > head/sbin/md5/md5.1 > head/sbin/md5/md5.c > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sha256.c > head/sys/conf/files > head/sys/crypto/sha2/sha256.h > head/sys/dev/random/build.sh > head/sys/dev/random/fortuna.c > head/sys/dev/random/hash.c > head/sys/dev/random/other_algorithm.c > head/sys/dev/random/randomdev.c > head/sys/dev/random/unit_test.c > head/sys/dev/random/yarrow.c > head/sys/geom/bde/g_bde.c > head/sys/geom/bde/g_bde_crypt.c > head/sys/geom/bde/g_bde_lock.c > head/sys/geom/bde/g_bde_work.c > head/sys/geom/eli/g_eli.h > head/sys/modules/crypto/Makefile > head/sys/modules/geom/geom_bde/Makefile > head/sys/modules/zfs/Makefile > head/sys/netinet/sctp_os_bsd.h > head/sys/opencrypto/xform.h > > Modified: head/lib/libcrypt/Makefile > Hi Allan! Could you please bump __FreeBSD_version after this change? This breaks the building of some external module, whose use the crypto/sha2/sha2.h file.