From owner-svn-src-head@FreeBSD.ORG Tue Dec 23 18:23:15 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A61F21065674; Tue, 23 Dec 2008 18:23:15 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id 85B508FC12; Tue, 23 Dec 2008 18:23:15 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.2/8.14.2) with ESMTP id mBNINFRH027128; Tue, 23 Dec 2008 10:23:15 -0800 (PST) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.2/8.14.2/Submit) id mBNINE30027127; Tue, 23 Dec 2008 10:23:14 -0800 (PST) (envelope-from obrien) Date: Tue, 23 Dec 2008 10:23:14 -0800 From: "David O'Brien" To: "Carlos A. M. dos Santos" Message-ID: <20081223182314.GC25145@dragon.NUXI.org> References: <200812192020.mBJKKEIo081792@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 8.0-CURRENT User-Agent: Mutt/1.5.16 (2007-06-09) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186337 - head/usr.sbin/burncd X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Dec 2008 18:23:15 -0000 On Sun, Dec 21, 2008 at 10:15:21AM -0200, Carlos A. M. dos Santos wrote: > On Fri, Dec 19, 2008 at 6:20 PM, David E. O'Brien wrote: > > Author: obrien > > Date: Fri Dec 19 20:20:14 2008 > > New Revision: 186337 > > URL: http://svn.freebsd.org/changeset/base/186337 > > > > Log: > > burncd(8) doesn't handle signals and interrupting burncd during operation. > > For example, ^C (SIGINT) may leave the drive spinning and locked. > > This may also happen if you try to write a too-large image to a disc > > and burncd(8) exits with an I/O error. > > > > Add signal handling by doing a CDRIOCFLUSH ioctl to attempt to leave > > burner in a sane state when burning is interrupted with SIGHUP, SIGINT, > > SIGTERM, or in case an I/O error occurs during write. > > Note, that blanking will still continue after interrupt but it seems to > > finish correctly even after burncd(8) has quit. > > > > Also, while I'm here bump WARNS to "6". > > > > PR: 48730 > > Submitted by: Jaakko Heinonen > > While you are here, would you mind taking a look at bin/123693, either > committing the proposed patch or closing the PR if my proposition is > not acceptable? Yep, I already have that patch to look at. Note it was hell getting the patch - its best to not attach it when it will be base64 encoded - we have no easy way of extracting such encoded attachements. -- -- David (obrien@FreeBSD.org)