From owner-cvs-all Mon May 20 0:13:14 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.datanet.hu (mx1.datanet.hu [194.149.13.165]) by hub.freebsd.org (Postfix) with ESMTP id C1E4C37B411 for ; Mon, 20 May 2002 00:13:09 -0700 (PDT) Received: from fonix.adamsfamily.xx (nilus-1644.adsl.datanet.hu [195.56.94.120]) by mx1.datanet.hu (DataNet) with ESMTP id DDD1A26B075 for ; Mon, 20 May 2002 09:13:03 +0200 (CEST) Received: from fonix.adamsfamily.xx (localhost [127.0.0.1]) by fonix.adamsfamily.xx (8.12.3/8.12.3) with ESMTP id g4K7DXFq024710 for ; Mon, 20 May 2002 09:13:34 +0200 (CEST) (envelope-from sziszi@bsd.hu) Received: (from cc@localhost) by fonix.adamsfamily.xx (8.12.3/8.12.3/Submit) id g4K7DXQT024694 for cvs-all@FreeBSD.ORG; Mon, 20 May 2002 09:13:33 +0200 (CEST) X-Authentication-Warning: fonix.adamsfamily.xx: cc set sender to sziszi@bsd.hu using -f Date: Mon, 20 May 2002 09:13:32 +0200 From: Szilveszter Adam To: cvs-all@FreeBSD.ORG Subject: Re: World breakage (was: cvs commit: src/share/doc/psd/03.iosys Makefile iosys) Message-ID: <20020520071332.GA607@fonix.adamsfamily.xx> Mail-Followup-To: Szilveszter Adam , cvs-all@FreeBSD.ORG References: <200205190603.g4J636l46087@freefall.freebsd.org> <20020519165158.A88638-100000@patrocles.silby.com> <20020520110840.O54769@wantadilla.lemis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020520110840.O54769@wantadilla.lemis.com> User-Agent: Mutt/1.3.99i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hello, On Mon, May 20, 2002 at 11:08:40AM +0930, Greg 'groggy' Lehey wrote: > On Sunday, 19 May 2002 at 16:52:40 -0500, Mike Silbersack wrote: <...> > > ===> share/doc/psd/03.iosys > > groff -ms iosys > paper.ps > > troff: fatal error: can't open `iosys': No such file or directory > > *** Error code 1 > > > > /me frowns at the broken buildworld. > > This is really puzzling. Of course I tried a build before I committed > all this stuff, notably the top-level Makefile. There seem to be > three differing views about what was broken: <..> In my opinion, save for psd/17.m4, which was broken in the way you described, the others were a casualty of not building them in obj dirs, in a manner similar to "world". Your Makefiles had custom targets that completely disabled the infrastructure in bsd.doc.mk, so they only could work if you did not use separate obj dirs. I do not think that they were tested with "make obj && make && make install" were they? All I had to do (and I tried to explain this in my previous email, but there was no reaction to that so I assumed there was no interest) was to actually delete all the custom targets and let bsd.doc.mk do its job. I added USE_TBL=yes and USE_REFER=yes and USE_PIC=yes where appropriate and the docs built fine, except for a bunch of warnings from refer, but you said there were warnings and so I ignored them. The resultant output looks ok to me with zmore. I managed to build all of the docs, save for 17.m4 in this way. As for installation, that was a bit funky, I admit, because you neglected to update the /etc/mtree/BSD.usr.dist file with the new directories (and I did not catch it either) and therefore the files were installed as eg "01.cacm" instead of 01.cacm/paper.ascii.gz. But this was again easy to fix and could have been avoided by going with the previous examples that are already in the tree. > I've committed some patches from mark, which probably allow things to > build. They ignore references to refer, though, so we end up with > even more warnings. There's also the issue of formats: I consider the > typeset version of the documents to be the canonical one, and while we > shouldn't install that on the system, I think it should be built. The > current method is not very clean IMO. When I set the PRINTERDEVICE to "ps", a valid PS representation of the docs was built, only these are not the default. So, I think that instead of providing custom and overriding targets in your Makefiles (which, btw, included invoking "spell", although that one surely is not part of the base and even a custom "clean" target) the bsd.doc.mk infrastructure should be improved in such a way that you can specify something like: PRINTERDEVICE= ps ascii and then both will be built. This is not possible at present, but it should not be a big deal. Maybe even I can submit a patch. The docs infrastructure does something similar already, so it is probably just a matter of BACnP (Brain-Aided Copy'n'Pasting). Or did you understand something else under "typeset version"? -- Regards: Szilveszter ADAM Szombathely Hungary To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message