From owner-freebsd-net Fri Nov 23 8:19:39 2001 Delivered-To: freebsd-net@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id 42B6A37B419 for ; Fri, 23 Nov 2001 08:19:27 -0800 (PST) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.6/8.11.2) id fANGJ4T70212; Fri, 23 Nov 2001 18:19:04 +0200 (EET) (envelope-from ru) Date: Fri, 23 Nov 2001 18:19:04 +0200 From: Ruslan Ermilov To: Dima Dorfman Cc: net@FreeBSD.ORG Subject: Re: Fix icmp_reflect if no addresses are configured Message-ID: <20011123181904.A69647@sunbay.com> References: <20011123161119.B9BA13F86@bazooka.trit.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20011123161119.B9BA13F86@bazooka.trit.org> User-Agent: Mutt/1.3.23i Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Fri, Nov 23, 2001 at 04:11:14PM +0000, Dima Dorfman wrote: > Please review the following change, from NetBSD: > > In icmp_reflect(): If the packet was not addressed to us and was > received on an interface without an IP address, try to find a > non-loopback AF_INET address to use. If that fails, drop it. > Previously, we used the address at the top of the in_ifaddrhead list, > which didn't make much sense, and would cause a panic if there were no > AF_INET addresses configured on the system. > > This fixes PRs 29337 and 30524. > Looks great. Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message