From owner-cvs-all Mon Nov 19 10:31: 9 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by hub.freebsd.org (Postfix) with ESMTP id BC23F37B417; Mon, 19 Nov 2001 10:31:00 -0800 (PST) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [fec0::1:12]) by Awfulhak.org (8.11.6/8.11.6) with ESMTP id fAJIUwi45986; Mon, 19 Nov 2001 18:30:58 GMT (envelope-from brian@freebsd-services.com) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.6/8.11.6) with ESMTP id fAJIUqv15801; Mon, 19 Nov 2001 18:30:52 GMT (envelope-from brian@freebsd-services.com) Message-Id: <200111191830.fAJIUqv15801@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Akinori MUSHA Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man1 builtin.1 src/bin/sh Makefile builtins.def sh.1 src/bin/test test.1 test.c In-Reply-To: Message from Akinori MUSHA of "Sat, 17 Nov 2001 11:10:11 PST." <200111171910.fAHJABJ92986@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Date: Mon, 19 Nov 2001 18:30:52 +0000 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > knu 2001/11/17 11:10:11 PST > = > Modified files: > share/man/man1 builtin.1 = > bin/sh Makefile builtins.def sh.1 = > bin/test test.1 test.c = > Log: > Make test(1) a builtin command of our sh(1) for efficiency. The > binary size increase is 3,784 bytes (about 0.6%). > = > I don't drop the printf builtin while I'm here because some /etc/rc.*= > scripts seem to use it before mounting /usr where printf(1) resides. > = > Reviewed by: arch (sheldonh) > Inspired by: NetBSD, ksh > Clued by: ume (on how the printf builtin is used) > = > Revision Changes Path > 1.31 +5 -3 src/bin/sh/Makefile > 1.8 +2 -1 src/bin/sh/builtins.def > 1.56 +6 -3 src/bin/sh/sh.1 > 1.17 +9 -1 src/bin/test/test.1 > 1.32 +6 -1 src/bin/test/test.c > 1.14 +7 -1 src/share/man/man1/builtin.1 This breaks sh: $ echo "program-not-found; test" | sh When testcmd() is given an argv[] of { "test", NULL } *and* an error = has occurred, things go pear shaped. -- = Brian http://www.freebsd-services.com/ Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message