From owner-svn-src-all@freebsd.org Fri May 24 20:22:53 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 66C2B15B480B; Fri, 24 May 2019 20:22:53 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F1BD576576; Fri, 24 May 2019 20:22:52 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 965D4AA14; Fri, 24 May 2019 20:22:52 +0000 (UTC) Date: Fri, 24 May 2019 20:22:52 +0000 From: Alexey Dokuchaev To: Justin Hibbits Cc: Piotr Kubaj , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r348250 - head/sys/powerpc/conf Message-ID: <20190524202252.GA72774@FreeBSD.org> References: <201905242001.x4OK1xA6091025@repo.freebsd.org> <20190524151651.7e6b7f09@titan.knownspace> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190524151651.7e6b7f09@titan.knownspace> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: F1BD576576 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.95)[-0.955,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 May 2019 20:22:53 -0000 On Fri, May 24, 2019 at 03:16:51PM -0500, Justin Hibbits wrote: > On Fri, 24 May 2019 20:01:59 +0000 (UTC) Piotr Kubaj wrote: > > New Revision: 348250 > > URL: https://svnweb.freebsd.org/changeset/base/348250 > > > > Log: > > Add snd_hda(4) to GENERIC64 used by powerpc64. > > > > amd64 also has snd_hda(4) in GENERIC. > > > > Modified: > > head/sys/powerpc/conf/GENERIC64 > > ... > > To note: This was done because there's a strange bug in the snd_hda > module, with the hdaa component. For some reason it either doesn't > find all the internal components it needs, or something, because > there's a NULL dereference when trying to call a kobj method in > hdaa_attach(). So this commit essentially masks the real bug somewhere rather than fixing it, is this what you're saying? ./danfe