From owner-freebsd-hackers@FreeBSD.ORG Fri Feb 11 17:06:09 2011 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E5E161065697; Fri, 11 Feb 2011 17:06:09 +0000 (UTC) (envelope-from webmaster@kibab.com) Received: from mx0.deglitch.com (cl-414.sto-01.se.sixxs.net [IPv6:2001:16d8:ff00:19d::2]) by mx1.freebsd.org (Postfix) with ESMTP id 9020E8FC22; Fri, 11 Feb 2011 17:06:09 +0000 (UTC) Received: from kibab-nb.kibab.com (p5099b4c2.dip0.t-ipconnect.de [80.153.180.194]) by mx0.deglitch.com (Postfix) with ESMTPSA id D347A8FC2E; Fri, 11 Feb 2011 20:06:01 +0300 (MSK) Message-ID: <4D556CAB.5020703@kibab.com> Date: Fri, 11 Feb 2011 18:06:51 +0100 From: Ilya Bakulin User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.2.9) Gecko/20101007 Thunderbird/3.1.4 MIME-Version: 1.0 To: Anonymous References: <20110211103028.12684f54yrw8tgqo@webmail.leidinger.net> <86zkq27ci9.fsf@gmail.com> In-Reply-To: <86zkq27ci9.fsf@gmail.com> X-Enigmail-Version: 1.1.2 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigF15FBABD9442F0ACC540C8F9" Cc: Alexander Leidinger , hackers@freebsd.org, kibab@freebsd.org Subject: Re: CFR: FEATURE macros for AUDIT/CAM/IPC/KTR/MAC/NFS/NTP/PMC/SYSV/... X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Feb 2011 17:06:10 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF15FBABD9442F0ACC540C8F9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11.02.2011 17:38, Anonymous wrote: > Alexander Leidinger writes: > >> Hi, >> >> during the last GSoC various FEATURE macros where added to the system.= >> Before committing them, I would like to get some review (like if macro= >> is in the correct file, and for those FEATURES where the description >> was not taken from NOTES if the description is OK). >> >> If nobody complains, I would like to commit this in 1-2 weeks. If you >> need more time to review, just tell me. > [...] >> Index: kern/kern_dtrace.c > [...] >> +FEATURE(kdtrace_hooks, >> + "Kernel DTrace hooks which are required to load DTrace kernel mod= ules"); >> + > [...] >> Index: kern/kern_lockstat.c > [...] >> +FEATURE(kdtrace_hooks, "Kernel DTRACE hooks"); > Why description differs? > > !DSPAM:4d556bc9311932017213797! > > It was a mistake on my side, I've already removed duplicate definition in Perforce. Thank you for pointing this out though! --=20 Regards, Ilya Bakulin http://kibab.com xmpp://kibab612@jabber.ru --------------enigF15FBABD9442F0ACC540C8F9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk1VbK0ACgkQo9vlj1oadwj/UwCg5PUpPqj/Kob8020co+XiZAvt 2JYAoIe737c1U0vLzcxoOA9MD80jO901 =hoQD -----END PGP SIGNATURE----- --------------enigF15FBABD9442F0ACC540C8F9--