From owner-freebsd-current@FreeBSD.ORG Mon Aug 23 14:57:46 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D8A1A1065672 for ; Mon, 23 Aug 2010 14:57:46 +0000 (UTC) (envelope-from ianf@clue.co.za) Received: from inbound01.jnb1.gp-online.net (inbound01.jnb1.gp-online.net [41.161.16.135]) by mx1.freebsd.org (Postfix) with ESMTP id 6F9DE8FC1B for ; Mon, 23 Aug 2010 14:57:46 +0000 (UTC) Received: from [41.154.88.19] (helo=clue.co.za) by inbound01.jnb1.gp-online.net with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1OnYT2-0004ho-04; Mon, 23 Aug 2010 16:57:44 +0200 Received: from localhost ([127.0.0.1] helo=clue.co.za) by clue.co.za with esmtp (Exim 4.72 (FreeBSD)) (envelope-from ) id 1OnYSy-0001e9-Vv; Mon, 23 Aug 2010 16:57:41 +0200 Message-Id: From: Ian FREISLICH In-Reply-To: References: <20100823140149.GG2396@deviant.kiev.zoral.com.ua> <201008230826.49509.jhb@freebsd.org> <20100823132551.GE2396@deviant.kiev.zoral.com.ua> <20100823133555.GA64651@hoeg.nl> <20100823134459.GF2396@deviant.kiev.zoral.com.ua> <20100823134723.GC64651@hoeg.nl> X-Attribution: BOFH Date: Mon, 23 Aug 2010 16:57:40 +0200 Cc: Kostik Belousov , Ed Schouten , freebsd-current@freebsd.org Subject: Re: fusefs-kmod broken? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Aug 2010 14:57:46 -0000 Ian FREISLICH wrote: > So, in this case is the fusefs module broken? I'm guessing it is. > I don't like the way fuse_fileops is initialised in fuse4bsd. I > would prefer for the struct to be zeroed and then the fo_xxx > implimented bits set as appropriate. That way when the struct is > changed, you don't get stung again. I am an idiot - that will have no effect. This patch needs to be included in sysutils/fusefs-kmod/files -- Ian Freislich patch-fuse_module__fuse_main.c --- fuse_module/fuse_main.c.orig 2010-08-23 16:52:20.000000000 +0200 +++ fuse_module/fuse_main.c 2010-08-23 16:48:17.000000000 +0200 @@ -108,6 +108,7 @@ switch (what) { case MOD_LOAD: /* kldload */ + fuse_fileops.fo_truncate = vnops.fo_truncate; fuse_fileops.fo_ioctl = vnops.fo_ioctl; fuse_fileops.fo_poll = vnops.fo_poll; fuse_fileops.fo_kqfilter = vnops.fo_kqfilter;