From owner-freebsd-audit  Thu Jun 28 16:58:40 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138])
	by hub.freebsd.org (Postfix) with ESMTP id AC0CD37B40A
	for <audit@FreeBSD.ORG>; Thu, 28 Jun 2001 16:58:38 -0700 (PDT)
	(envelope-from dima@unixfreak.org)
Received: from hornet.unixfreak.org (hornet [63.198.170.140])
	by bazooka.unixfreak.org (Postfix) with ESMTP
	id 23EE83E2F; Thu, 28 Jun 2001 16:58:32 -0700 (PDT)
To: Alexander Langer <alex@big.endian.de>
Cc: Thomas Zenker <thz@Lennartz-electronic.de>, audit@FreeBSD.ORG
Subject: Re: bin/27029: strptime: %s formatting missing (patch) 
In-Reply-To: <20010629014313.A7351@zerogravity.kawo2.rwth-aachen.d>; from alex@big.endian.de on "Fri, 29 Jun 2001 01:43:13 +0200"
Date: Thu, 28 Jun 2001 16:58:32 -0700
From: Dima Dorfman <dima@unixfreak.org>
Message-Id: <20010628235832.23EE83E2F@bazooka.unixfreak.org>
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

Alexander Langer <alex@big.endian.de> writes:
> Also sprach Thomas Zenker (thz@Lennartz-electronic.de):
> 
> 		[... case 'Z':]
> Please keep the order.

If you look at that switch, they're already so out of order that it
isn't clear where this should go.

> 
> >  			}
> >  			}
> >  			break;
> > +		case 's':
> > +			{
> > +			time_t t;
> > +			const char *cp;
> > +			t = strtol(buf, &cp, 10);
> 
> Is time_t long again on all branches?
> I think David (obrien) backed it out on -STABLE, IIRC.

IIRC it's an int on most branches, but using strtol is still okay there.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message