Date: Sat, 5 Aug 1995 11:16:38 +1000 From: Bruce Evans <bde@zeta.org.au> To: joerg@freefall.cdrom.com, rgrimes@gndrsh.aac.dev.com Cc: CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com Subject: Re: cvs commit: src/usr.bin/xinstall xinstall.c Message-ID: <199508050116.LAA26907@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>> Modified: usr.bin/xinstall xinstall.c >> Log: >> Make install not remove the target file if -s has been specified but >> stripping failed (since the file has been a shell script, for >> example). >Ignoring error conditions from strip is not a good idea. Using -s option >to install non binary files is a usage error. I thought the patch in the PR was so obviously wrong that it wouldn't be applied. >Removing the file if strip failed is probably not the right thing to `install' has already unlinked the original file so there's nothing better to do than to remove the results of the usage error. >do, but being silent about strip errors is not a good idea. Yes. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199508050116.LAA26907>