Date: Wed, 5 Jul 2023 10:13:45 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: Raphael Kubo da Costa <rakuco@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: b56d0bc41af7 - main - devel/libcutl: Explain why USE_CXXSTD=c++11 is used Message-ID: <CAFDf7UJRc4bd3XVq%2Bb7Za2cLN7h_hkN1mpPTGQiSajV1p9A=0g@mail.gmail.com> In-Reply-To: <202307050850.3658oPOA049562@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Hello Raphael, Really nice and explaining comment on std c++11 fixes. I will use same comment on ports needed it to work in clang 16, e.g., net-p2p/amule that needs it. Just a question, should a PORTREVISION bump reccomended when we set USE_CXXSTD=c++11? Thanks, Raphael Kubo da Costa <rakuco@freebsd.org> escreveu no dia quarta, 5/07/2023 à(s) 09:50: > The branch main has been updated by rakuco: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=b56d0bc41af79bf3a51f89249e96ec02b7fc464e > > commit b56d0bc41af79bf3a51f89249e96ec02b7fc464e > Author: Raphael Kubo da Costa <rakuco@FreeBSD.org> > AuthorDate: 2023-07-05 08:49:09 +0000 > Commit: Raphael Kubo da Costa <rakuco@FreeBSD.org> > CommitDate: 2023-07-05 08:49:09 +0000 > > devel/libcutl: Explain why USE_CXXSTD=c++11 is used > > While here, also add a note to its only consumer, devel/xsd, to mention > why it also needs USE_CXXSTD and when it can be removed. > --- > devel/libcutl/Makefile | 2 ++ > devel/xsd/Makefile | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/devel/libcutl/Makefile b/devel/libcutl/Makefile > index 323b2b44feee..bbaad70028c2 100644 > --- a/devel/libcutl/Makefile > +++ b/devel/libcutl/Makefile > @@ -17,6 +17,8 @@ LIB_DEPENDS= libboost_system.so:devel/boost-libs \ > libexpat.so:textproc/expat2 > > USES= compiler:c++11-lib libtool > +# libcutl 1.10.0 is not compatible with C++17, which is the default since > clang > +# 16. This means ports depending on it also need to use at most C++14. > USE_CXXSTD= c++11 > GNU_CONFIGURE= yes > INSTALL_TARGET= install-strip > diff --git a/devel/xsd/Makefile b/devel/xsd/Makefile > index 06e02ce6f72c..010b73e6e9e4 100644 > --- a/devel/xsd/Makefile > +++ b/devel/xsd/Makefile > @@ -23,6 +23,9 @@ LIB_DEPENDS= libcutl.so:devel/libcutl \ > libxerces-c.so:textproc/xerces-c3 > > USES= compiler:c++11-lang ghostscript:build gmake > localbase:ldflags tar:bzip2 > +# devel/libcutl 1.10.0 does not work with C++17 which is the default since > +# clang 16. This can be removed once that port starts working with C++17 > and > +# has its own USE_CXXSTD removed. > USE_CXXSTD= c++11 > > MAKEFILE= makefile > -- Nuno Teixeira FreeBSD Committer (ports) [-- Attachment #2 --] <div dir="ltr"><div>Hello Raphael,</div><div><br></div><div>Really nice and explaining comment on std c++11 fixes. I will use same comment on ports needed it to work in clang 16, e.g., net-p2p/amule that needs it.<br><br></div><div>Just a question, should a PORTREVISION bump reccomended when we set USE_CXXSTD=c++11?</div><div><br></div><div>Thanks,<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Raphael Kubo da Costa <<a href="mailto:rakuco@freebsd.org">rakuco@freebsd.org</a>> escreveu no dia quarta, 5/07/2023 à(s) 09:50:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has been updated by rakuco:<br> <br> URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=b56d0bc41af79bf3a51f89249e96ec02b7fc464e" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=b56d0bc41af79bf3a51f89249e96ec02b7fc464e</a><br>; <br> commit b56d0bc41af79bf3a51f89249e96ec02b7fc464e<br> Author: Raphael Kubo da Costa <rakuco@FreeBSD.org><br> AuthorDate: 2023-07-05 08:49:09 +0000<br> Commit: Raphael Kubo da Costa <rakuco@FreeBSD.org><br> CommitDate: 2023-07-05 08:49:09 +0000<br> <br> devel/libcutl: Explain why USE_CXXSTD=c++11 is used<br> <br> While here, also add a note to its only consumer, devel/xsd, to mention<br> why it also needs USE_CXXSTD and when it can be removed.<br> ---<br> devel/libcutl/Makefile | 2 ++<br> devel/xsd/Makefile | 3 +++<br> 2 files changed, 5 insertions(+)<br> <br> diff --git a/devel/libcutl/Makefile b/devel/libcutl/Makefile<br> index 323b2b44feee..bbaad70028c2 100644<br> --- a/devel/libcutl/Makefile<br> +++ b/devel/libcutl/Makefile<br> @@ -17,6 +17,8 @@ LIB_DEPENDS= libboost_system.so:devel/boost-libs \<br> libexpat.so:textproc/expat2<br> <br> USES= compiler:c++11-lib libtool<br> +# libcutl 1.10.0 is not compatible with C++17, which is the default since clang<br> +# 16. This means ports depending on it also need to use at most C++14.<br> USE_CXXSTD= c++11<br> GNU_CONFIGURE= yes<br> INSTALL_TARGET= install-strip<br> diff --git a/devel/xsd/Makefile b/devel/xsd/Makefile<br> index 06e02ce6f72c..010b73e6e9e4 100644<br> --- a/devel/xsd/Makefile<br> +++ b/devel/xsd/Makefile<br> @@ -23,6 +23,9 @@ LIB_DEPENDS= libcutl.so:devel/libcutl \<br> libxerces-c.so:textproc/xerces-c3<br> <br> USES= compiler:c++11-lang ghostscript:build gmake localbase:ldflags tar:bzip2<br> +# devel/libcutl 1.10.0 does not work with C++17 which is the default since<br> +# clang 16. This can be removed once that port starts working with C++17 and<br> +# has its own USE_CXXSTD removed.<br> USE_CXXSTD= c++11<br> <br> MAKEFILE= makefile<br> </blockquote></div><br clear="all"><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><span style="color:rgb(102,102,102)">Nuno Teixeira<br>FreeBSD Committer (ports)</span></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UJRc4bd3XVq%2Bb7Za2cLN7h_hkN1mpPTGQiSajV1p9A=0g>