Date: Thu, 27 Jan 2000 09:39:30 -0700 From: Warner Losh <imp@village.org> To: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org> Cc: gallatin@cs.duke.edu, freebsd-mobile@FreeBSD.ORG Subject: Re: pc card removal lockup Message-ID: <200001271639.JAA45996@harmony.village.org> In-Reply-To: Your message of "Thu, 27 Jan 2000 17:56:26 %2B0900." <200001270856.RAA07853@tasogare.imasy.or.jp> References: <200001270856.RAA07853@tasogare.imasy.or.jp> <200001270824.BAA43895@harmony.village.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200001270856.RAA07853@tasogare.imasy.or.jp> Mitsuru IWASAKI writes: : Hi, : : > Hi isasaki-san, : : # my name is iwasaki :) I'm terribly sorry iwasaki-san. : I basically agree with you. I have two things to say. : : How about adding splhigh() and splx() around calling disable_slot() as : same as pccard_suspend()? It will make removal event handling more : safty, I beleave. It was there and took it out. I think that it can be added back w/o problem. : And Is disable_slot_to() necessary if we don't use spl0 code? : I think calling disable_slot() would be almost the same as the code in : pccard_suspend(). Yes. I think that moving disable_slot_to inline would be good. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200001271639.JAA45996>