Date: Sun, 24 Dec 2017 14:23:47 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Marcelo Araujo <araujo@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r456964 - in head/audio: . pc-mixer Message-ID: <20171224142347.GD1693@FreeBSD.org> In-Reply-To: <201712220249.vBM2nIOU084143@repo.freebsd.org> References: <201712220249.vBM2nIOU084143@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 22, 2017 at 02:49:18AM +0000, Marcelo Araujo wrote: > New Revision: 456964 > URL: https://svnweb.freebsd.org/changeset/ports/456964 > > Log: > Add pc-mixer version 20171212 part of Lumina desktop version 1.4.1. > > PR: ports/224305 > Submitted by: JT Pennington <jt@ixsystems.com> > Sponsored by: iXsystems, Inc. A few observations if you don't mind. > Added: head/audio/pc-mixer/Makefile > ... > @@ -0,0 +1,34 @@ > +# $FreeBSD$ > + > +PORTNAME= pc-mixer > +PORTVERSION= 20171212 > +CATEGORIES= audio > + > +MAINTAINER= jmaloney@ixsystems.com > +COMMENT= QT5 based audio mixer for FreeBSD QT is abbreviation for QuickTime; the toolkit is called "Qt". > +MAKE_JOBS_UNSAFE=yes Please include a reason in the commit log when (un)marking a port as jobs-unsafe: it would help interested developers to try to fix the problem. Short excerpt from the build log showing the failure would usually suffice. > +USE_GL+= gl Why += here? > +GH_PROJECT= pc-mixer This is the default and should've been dropped. > Added: head/audio/pc-mixer/pkg-descr > ... > @@ -0,0 +1,3 @@ > +TrueOS QT5 based audio mixer > + > +WWW: https://github.com/trueos/pc-mixer Port description should not simply rephrase or copy COMMENT, see Section 3.2.1 of the PHB. It should also be terminated with a full stop (dot). QT5 is spelled wrongly as noted above. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171224142347.GD1693>