From owner-freebsd-stable@FreeBSD.ORG Wed Sep 26 22:37:33 2007 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DC12516A417 for ; Wed, 26 Sep 2007 22:37:33 +0000 (UTC) (envelope-from imb@protected-networks.net) Received: from aaron.protected-networks.net (aaron.protected-networks.net [202.12.127.66]) by mx1.freebsd.org (Postfix) with ESMTP id 8477B13C4B0 for ; Wed, 26 Sep 2007 22:37:33 +0000 (UTC) (envelope-from imb@protected-networks.net) Received: from localhost (localhost [127.0.0.1]) by aaron.protected-networks.net (Postfix) with ESMTP id 867EDC655; Wed, 26 Sep 2007 18:20:57 -0400 (EDT) Received: from toshi.auburn.protected-networks.net (toshi.auburn.protected-networks.net [202.12.127.84]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "Iain Michael Butler", Issuer "Protected Networks Certificate Authority" (verified OK)) (Authenticated sender: imb@protected-networks.net) by aaron.protected-networks.net (Postfix) with ESMTP id 6ADA3C5E9; Wed, 26 Sep 2007 18:20:43 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=protected-networks.net; s=200705; t=1190845243; bh=QgKkXbMOv4lDK2 HC1OCOdAcBs6rfPWPQSE49AVi+G0E=; h=DomainKey-Signature:Message-ID: Date:From:User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:X-Enigmail-Version:OpenPGP:Content-Type; b=kvHf5ClkWNS lIMfEtT4jj2cddybDTxiQoV42sx80KKrUjsWtcdeMLy4IKEbghxk1gT6URhVPbxErxU 4yKUoCV38Mt6JJwOvxom4gjO+84ysD/1tI7RAgJTy/YbCkac+h DomainKey-Signature: a=rsa-sha1; s=200509; d=protected-networks.net; c=nofws; q=dns; h=message-id:date:from:user-agent:mime-version:to:cc:subject: references:in-reply-to:x-enigmail-version:openpgp:content-type; b=BnD7x9zQbWF7SyoWO0QDnH1D3DZOMM7YATB0upIbjM5D3Wwff7jcXiw91DuQLUINt g1wZWxfBnxr+AqHBtGJf6ABBtC62j/0AV1VU2EbJhkFVz8WebQhsVCcj6IiEhya Message-ID: <46FADB39.6000704@protected-networks.net> Date: Wed, 26 Sep 2007 18:20:41 -0400 From: Michael Butler User-Agent: Thunderbird 2.0.0.6 (X11/20070903) MIME-Version: 1.0 To: Chris References: <3aaaa3a0709261509g414e3163mff45f9da3bc4d7f3@mail.gmail.com> In-Reply-To: <3aaaa3a0709261509g414e3163mff45f9da3bc4d7f3@mail.gmail.com> X-Enigmail-Version: 0.95.2 OpenPGP: id=0442D492 Content-Type: multipart/mixed; boundary="------------070903000003070809000406" Cc: FreeBSD Stable , =?ISO-8859-1?Q?S=F8ren_?=, =?ISO-8859-1?Q?Schmidt?= Subject: Re: gbde and geli on 6.2 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2007 22:37:33 -0000 This is a multi-part message in MIME format. --------------070903000003070809000406 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Chris wrote: > Hi I am concerned about the availabilities of these encryptions in > freebsd releases that are marked stable. > > It seems gbde has a problem when the the data written goes over the > lba boundary around lba48. Could you please test the attached patch to /usr/src/sys/dev/ata/ata-all.c ? I believe this may be due to the error in the underlying ata driver rather than specifically to do with encryption. As a side note - Soren, could we get this commited to both -current and -stable if there aren't any significant objections? Michael --------------070903000003070809000406 Content-Type: text/x-patch; name="ata-all.c.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="ata-all.c.diff" *** ata-all.c~ Thu Aug 30 17:23:15 2007 --- ata-all.c Thu Aug 30 17:23:15 2007 *************** *** 743,749 **** atadev->flags &= ~ATA_D_48BIT_ACTIVE; ! if ((request->u.ata.lba >= ATA_MAX_28BIT_LBA || request->u.ata.count > 256) && atadev->param.support.command2 & ATA_SUPPORT_ADDRESS48) { --- 743,749 ---- atadev->flags &= ~ATA_D_48BIT_ACTIVE; ! if (((request->u.ata.lba + request->u.ata.count) >= ATA_MAX_28BIT_LBA || request->u.ata.count > 256) && atadev->param.support.command2 & ATA_SUPPORT_ADDRESS48) { --------------070903000003070809000406--