From nobody Wed Oct 11 01:34:26 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S4wLF21gHz4wdn7 for ; Wed, 11 Oct 2023 01:34:45 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S4wLD6JFFz4YvF for ; Wed, 11 Oct 2023 01:34:44 +0000 (UTC) (envelope-from adamw@adamw.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9b29186e20aso1070786466b.2 for ; Tue, 10 Oct 2023 18:34:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20230601.gappssmtp.com; s=20230601; t=1696988082; x=1697592882; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=xLcI94pRsLVYdmn42zwhJZ5XXrayupftM/FeH/PMnjk=; b=ujvOY0WngI9uuCXw1stuARdImV8V8ITzs1+jm3TqM7bY8yHACcdxLp+VnVytmQzoOh VNwtcnYPX5YQzkTkOoBneHcsS3SOmtICgPChv0eOks6Ye9ImIq1i7h+mRdMTgo3WXKqP ZivqUHKXEsixt9MC8o+KGQJKuRUrjP62/Pm0BQytqF5hhSomDBs/2oMlGFZvGQmZBmtu Oy9dVDTMl1U2jtJg2Cx5pi4oDr7RTGiJkIrFqed2agVDN6JoxRPnM3FbQZb9U0myhVhu T0x3W4QRgf2HUqY0jCgRRMEDiY4iQGBRgGLq4/GKdzvu7uNi7s3cRr15IK28c+yyFIeZ 7o+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696988082; x=1697592882; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xLcI94pRsLVYdmn42zwhJZ5XXrayupftM/FeH/PMnjk=; b=rfLvgi1uHSSO19kVT6ZD8PkrTrXNSRO+PKkkx4fYIJ1senxUVlDpBtpqbr+pgsT+Mh 4VNr5CRlVIxSED0nDtLU5bPuxu7WhEQLaMH49gqF+lF6a39msSeyHfXwMOVp/vYKIXvs cM7ggeTD5oAJtUCe7fJ1Py0l4pJdli4qfXe8w97NRzlvYGJkGe64nYWGhj6rzwhhuYDC sXhit/BWr3vposWIaoXKhLOkmpdHD4VQt9y1UWh8TgJl9eOKBRmrX+hvPvrpoIuzzuik RT6AgIB4YtBb4T9TcvTuzDJHdmSQNn79PrujVUEuhkTPSxNDBfgsSYagFjwuDyb9zrS0 jaCw== X-Gm-Message-State: AOJu0Yy64kFAmlNd32gKZmBL5nDWn1igX11j62xeJwZf9TWZtbPzX2Ov uKLFX6WYYdoLaLekMMc6JKTrorjsMsux2YswqMrWyw== X-Google-Smtp-Source: AGHT+IGiEugF4W0Dphc/mYPKiQLcBJsKEuKllG/vBim+koL3/tQ6qly7qsJ8cVLCcGPeT2QULlB4xuNPzeMYzwY9+Ns= X-Received: by 2002:a17:906:51d5:b0:9b2:ba66:bbb0 with SMTP id v21-20020a17090651d500b009b2ba66bbb0mr16623059ejk.28.1696988082440; Tue, 10 Oct 2023 18:34:42 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202310101158.39ABwYv1037813@gitrepo.freebsd.org> In-Reply-To: <202310101158.39ABwYv1037813@gitrepo.freebsd.org> From: Adam Weinberger Date: Tue, 10 Oct 2023 21:34:26 -0400 Message-ID: Subject: Re: git: 0e73ed9372f0 - main - config: switch from dialog4ports to portconfig To: Baptiste Daroussin Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000d799c2060766d355" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4S4wLD6JFFz4YvF --000000000000d799c2060766d355 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Baptiste, The DIALOG4PORTS option from poudriere probably needs to be switched to a PORTCONFIG option. # Adam On Tue, Oct 10, 2023 at 7:58=E2=80=AFAM Baptiste Daroussin wrote: > The branch main has been updated by bapt: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3D0e73ed9372f074ba59d40b66b95c8= 78a7f36702e > > commit 0e73ed9372f074ba59d40b66b95c878a7f36702e > Author: Baptiste Daroussin > AuthorDate: 2023-10-10 11:53:44 +0000 > Commit: Baptiste Daroussin > CommitDate: 2023-10-10 11:58:31 +0000 > > config: switch from dialog4ports to portconfig > > dialog4ports is using libdialog which is being decommissioned from > base replaced by bsddialog. We cannot switch to depending on > devel/cdialog because it build depends on too many things, on the oth= er > hand the author of bsddialog made portconfig as a drop-in replacement > for dialog4ports, it only build depends on devel/bsddialog (we use > the version in port to be sure to have the right version on all > supported versions of the ports tree) > > Reported by: Herbert J. Skuhra" > --- > Mk/Scripts/dialog4ports.sh | 4 ++-- > Mk/bsd.commands.mk | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Mk/Scripts/dialog4ports.sh b/Mk/Scripts/dialog4ports.sh > index e229d7d4bdc1..de62a91b583f 100644 > --- a/Mk/Scripts/dialog4ports.sh > +++ b/Mk/Scripts/dialog4ports.sh > @@ -10,8 +10,8 @@ if [ -z "${DIALOG4PORTS}" -o -z "${PORTSDIR}" -o -z > "${MAKE}" ]; then > exit 1 > fi > > -: ${DIALOGPORT:=3Dports-mgmt/dialog4ports} > -: ${DIALOGNAME:=3Ddialog4ports} > +: ${DIALOGPORT:=3Dports-mgmt/portconfig} > +: ${DIALOGNAME:=3Dportconfig} > > OPTIONSFILE=3D"$1" > > diff --git a/Mk/bsd.commands.mk b/Mk/bsd.commands.mk > index 7addad889763..636f2f2f481e 100644 > --- a/Mk/bsd.commands.mk > +++ b/Mk/bsd.commands.mk > @@ -33,7 +33,7 @@ DIALOG?=3D /usr/bin/dialog > .else > DIALOG?=3D /usr/bin/bsddialog > .endif > -DIALOG4PORTS?=3D ${LOCALBASE}/bin/dialog4ports > +DIALOG4PORTS?=3D ${LOCALBASE}/bin/portconfig > DIFF?=3D /usr/bin/diff > DIRNAME?=3D /usr/bin/dirname > EGREP?=3D /usr/bin/egrep > --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org --000000000000d799c2060766d355 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Baptiste,

The DIALOG4PORTS option from poudriere probably nee= ds to be switched to a PORTCONFIG option.

# Adam



On Tue, Oct 10= , 2023 at 7:58=E2=80=AFAM Baptiste Daroussin <bapt@freebsd.org> wrote:
The branch main has been updated by bapt:

URL: https://cgi= t.FreeBSD.org/ports/commit/?id=3D0e73ed9372f074ba59d40b66b95c878a7f36702e

commit 0e73ed9372f074ba59d40b66b95c878a7f36702e
Author:=C2=A0 =C2=A0 =C2=A0Baptiste Daroussin <bapt@FreeBSD.org>
AuthorDate: 2023-10-10 11:53:44 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Baptiste Daroussin <bapt@FreeBSD.org>
CommitDate: 2023-10-10 11:58:31 +0000

=C2=A0 =C2=A0 config: switch from dialog4ports to portconfig

=C2=A0 =C2=A0 dialog4ports is using libdialog which is being decommissioned= from
=C2=A0 =C2=A0 base replaced by bsddialog. We cannot switch to depending on<= br> =C2=A0 =C2=A0 devel/cdialog because it build depends on too many things, on= the other
=C2=A0 =C2=A0 hand the author of bsddialog made portconfig as a drop-in rep= lacement
=C2=A0 =C2=A0 for dialog4ports, it only build depends on devel/bsddialog (w= e use
=C2=A0 =C2=A0 the version in port to be sure to have the right version on a= ll
=C2=A0 =C2=A0 supported versions of the ports tree)

=C2=A0 =C2=A0 Reported by:=C2=A0 =C2=A0 Herbert J. Skuhra" <herbert@gojira.at> ---
=C2=A0Mk/Scripts/dialog4ports.sh | 4 ++--
=C2=A0Mk/bsd.commands.mk=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 2 +-
=C2=A02 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Mk/Scripts/dialog4ports.sh b/Mk/Scripts/dialog4ports.sh
index e229d7d4bdc1..de62a91b583f 100644
--- a/Mk/Scripts/dialog4ports.sh
+++ b/Mk/Scripts/dialog4ports.sh
@@ -10,8 +10,8 @@ if [ -z "${DIALOG4PORTS}" -o -z "${PORTSDI= R}" -o -z "${MAKE}" ]; then
=C2=A0 =C2=A0 =C2=A0 =C2=A0 exit 1
=C2=A0fi

-: ${DIALOGPORT:=3Dports-mgmt/dialog4ports}
-: ${DIALOGNAME:=3Ddialog4ports}
+: ${DIALOGPORT:=3Dports-mgmt/portconfig}
+: ${DIALOGNAME:=3Dportconfig}

=C2=A0OPTIONSFILE=3D"$1"

diff --git a/Mk/bsd.commands.mk b/Mk/bsd.commands.mk
index 7addad889763..636f2f2f481e 100644
--- a/Mk/bsd.commands.mk
+++ b/Mk/bsd.commands.mk
@@ -33,7 +33,7 @@ DIALOG?=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 /usr/bin/dialog
=C2=A0.else
=C2=A0DIALOG?=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/usr= /bin/bsddialog
=C2=A0.endif
-DIALOG4PORTS?=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0${LOCALBASE}/bin/dialog4= ports
+DIALOG4PORTS?=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0${LOCALBASE}/bin/portcon= fig
=C2=A0DIFF?=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0/usr/bin/diff
=C2=A0DIRNAME?=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /usr/bin/= dirname
=C2=A0EGREP?=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 /usr/bin/egrep


--
--000000000000d799c2060766d355--