From nobody Thu Sep 21 22:28:10 2023 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rs95k5TBQz4v5NS for ; Thu, 21 Sep 2023 22:28:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rs95k4QlGz4JFb for ; Thu, 21 Sep 2023 22:28:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695335290; a=rsa-sha256; cv=none; b=sNOB15uVMkYoisTGjjk+Geyv88mJt/KWEY7mVdFPofC7/hpwKmXs2nJfhcpA7SBNQiGciL 0We5CZtC0IKXzC2rOTFC2rDHt2z1PvFkuvcgIELIJXjHLSwbUdjO0IPLfaZn7ZNqgJRVw3 uWjH3rJYoibtimHYfaBYF9IumV5dSd3GjOlft8bbENJHzM23yQ3SVQ0HBnrCsekGpz3fA0 S+l5c3SPaFo0rqudUk51voBvra5BPWQbzAX9FzpLytU6sMGIdQ17R7JUTVK8RQ89WDqYvC /644rW0hS9LV5ubxLBU+JwBQG3zx+1FY7u/V3zY28PP95XvwGo5lR2ks6Mq08w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695335290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M+s5CIg9ZglifjVY2S3gkYxQRMnbLZdO7gd6gz0GOso=; b=a2IQyo0IryVqgw8ZoVgnqtAB/pMvX3H1EqtUtpWDlinvlkKfOI0cHdnAN4ZX4KTj/scYvA Yp8wVbvVh5SJflKJMnSB0fYk6g6s2bw3QCydZr+8MMt7Fv24aMcPv6GnolWm9FOpeel5EY HAYvvi+LccLORZlAZKLKYT3Ec0xRV7rO3g3BWUHnQ/n+1Fh88Nq6HQ51PFs8a6+UyYDhLX E4cqnSyD4ays2XEmZsl8yt7B1uevLqExbLJhmP1DEN3qnSRP/N7rgP14oCMGfpep+ymHKy FLRUE55pl0MiR5xO3kgld95RCm8kYGYA1akCdCukcAbbge+xrsncZgDk1M16lQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rs95k3T0pzx0C for ; Thu, 21 Sep 2023 22:28:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 38LMSAbK078238 for ; Thu, 21 Sep 2023 22:28:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 38LMSARK078237 for fs@FreeBSD.org; Thu, 21 Sep 2023 22:28:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 273663] zfsd crashes in the presence of pools with removed TLVs Date: Thu, 21 Sep 2023 22:28:10 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 14.0-STABLE X-Bugzilla-Keywords: crash, regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: asomers@FreeBSD.org X-Bugzilla-Flags: mfc-stable13+ mfc-stable14+ mfc-stable12+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273663 --- Comment #15 from commit-hook@FreeBSD.org --- A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Db2dff90c0be7c92a228fdbee5f69335dc= c8044fb commit b2dff90c0be7c92a228fdbee5f69335dcc8044fb Author: Alan Somers AuthorDate: 2023-09-12 01:20:39 +0000 Commit: Alan Somers CommitDate: 2023-09-21 22:26:29 +0000 Fix zfsd with the device_removal pool feature. Previously zfsd would crash in the presence of a pool with a top-level-vdev that had previously been removed. The crash happened because the configuration nvlist of such a TLV contains an empty ZPOOL_CONFIG_CHILDREN array, which led to a pop_front from an empty list, which has undefined behavior. The crash only happened in stable/14 and later, probably do to differences in libcxx, but the change should be MFCed anyway. PR: 273663 Reported by: Marek Zarychta Sponsored by: Axcient Reviewed by: mav Differential Revision: https://reviews.freebsd.org/D41818 (cherry picked from commit 0b294a386d34f6584848ed52407687df7ae59861) cddl/usr.sbin/zfsd/tests/zfsd_unittest.cc | 37 +++++++++++++++++++++++++++= ++++ cddl/usr.sbin/zfsd/vdev_iterator.cc | 5 +---- 2 files changed, 38 insertions(+), 4 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=