From nobody Fri Dec 1 02:01:12 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ShGWT4Gmcz536Fr for ; Fri, 1 Dec 2023 02:01:25 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ShGWT2Rflz4Ytp for ; Fri, 1 Dec 2023 02:01:25 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-40b4746ae51so15273395e9.2 for ; Thu, 30 Nov 2023 18:01:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701396083; x=1702000883; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QKFd+Jxb0oXuHlwMiZtBLmOy7Uzh2MUg43CKQyVFyFU=; b=B3qIRFDI/T1bol6YzIvpqEZ3WZdPUpWC1bsg3kI224AZqCNeOEqxhkT3EyCP2xKUDc pUnhiuEccM18/qdrkO5hP0MtrQ3qXavLdxQcxFOjgjbS9ufqSdBKBzCOYpL5iXRQkAZ9 pt2weHxjot+iw5IKtGZi4q1If4JJnS5L6MC8ugkCBy8RHd02mnkKf1IGhjFhlQjSQy7+ 7b8UaZUPVITd4Bhh0QnOm99pce3fs9mSwZyWZDUCZ/EYx5G33LENAfrJUIcAHCu4giUX m1OTtRUAswTDiAux57HqmGqdmhi8+HLvvS2EGAhwUr9jMegInbQp7wKyOOIMP3S5tYgt Rn0w== X-Gm-Message-State: AOJu0YzJkvotuRRa4K3Y0G+/5w/nMNwGB9nb0AVZjF+PrXgpK3Q7yp4v Kn33QBZ/u8wTLNJf3Urhas8TNtRYbItXu9aLzl0= X-Google-Smtp-Source: AGHT+IEv4OR2T6WsXuENHWdjiqPi6UwI9IP30RTISwJEoxSXFGuNJQFx9TRiOK/8wMKNV4+G8V1dtw== X-Received: by 2002:a05:600c:b59:b0:40b:5e59:c55c with SMTP id k25-20020a05600c0b5900b0040b5e59c55cmr147555wmr.134.1701396083366; Thu, 30 Nov 2023 18:01:23 -0800 (PST) Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id v9-20020a05600c470900b004063cd8105csm7404644wmo.22.2023.11.30.18.01.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Nov 2023 18:01:22 -0800 (PST) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\)) Subject: Re: git: 682b069c5c56 - main - iicbus: add compat32 support for I2C ioctls From: Jessica Clarke In-Reply-To: <202312010133.3B11XtOU057326@gitrepo.freebsd.org> Date: Fri, 1 Dec 2023 02:01:12 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <40E00B2E-E8C1-4980-896D-D9620E685108@freebsd.org> References: <202312010133.3B11XtOU057326@gitrepo.freebsd.org> To: "Stephen J. Kiernan" X-Mailer: Apple Mail (2.3774.200.91.1.1) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4ShGWT2Rflz4Ytp On 1 Dec 2023, at 01:33, Stephen J. Kiernan wrote: >=20 > The branch main has been updated by stevek: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D682b069c5c5643d26199cc1b65717f99= c98bce9d >=20 > commit 682b069c5c5643d26199cc1b65717f99c98bce9d > Author: Stephen J. Kiernan > AuthorDate: 2023-11-29 19:20:45 +0000 > Commit: Stephen J. Kiernan > CommitDate: 2023-12-01 01:33:46 +0000 >=20 > iicbus: add compat32 support for I2C ioctls >=20 > Some of the I2C ioctl request structures contain pointers and need = to > handle requests from 32-bit applications on 64-bit kernels. >=20 > Obtained from: Juniper Networks, Inc. > Differential Revision: https://reviews.freebsd.org/D42836 > --- > sys/dev/iicbus/iic.c | 111 = +++++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 108 insertions(+), 3 deletions(-) >=20 > diff --git a/sys/dev/iicbus/iic.c b/sys/dev/iicbus/iic.c > index baaa7a096a14..8c9dbb6bc145 100644 > --- a/sys/dev/iicbus/iic.c > +++ b/sys/dev/iicbus/iic.c > @@ -2,6 +2,7 @@ > * SPDX-License-Identifier: BSD-2-Clause > * > * Copyright (c) 1998, 2001 Nicolas Souchu > + * Copyright (c) 2023 Juniper Networks, Inc. > * All rights reserved. > * > * Redistribution and use in source and binary forms, with or without > @@ -27,6 +28,7 @@ > * > */ > #include > +#include > #include > #include > #include > @@ -57,6 +59,30 @@ struct iic_cdevpriv { > uint8_t addr; > }; >=20 > +#ifdef COMPAT_FREEBSD32 > +struct iic_msg32 { > + uint16_t slave; > + uint16_t flags; > + uint16_t len; > + uint32_t buf; > +}; > + > +struct iiccmd32 { > + u_char slave; > + uint32_t count; > + uint32_t last; > + uint32_t buf; > +}; > + > +struct iic_rdwr_data32 { > + uint32_t msgs; > + uint32_t nmsgs; > +}; > + > +#define I2CWRITE32 _IOW('i', 4, struct iiccmd32) > +#define I2CREAD32 _IOW('i', 5, struct iiccmd32) > +#define I2CRDWR32 _IOW('i', 6, struct iic_rdwr_data32) > +#endif Like I said for smbus, please use _IOC_NEWTYPE. Jess