From owner-freebsd-bugs@FreeBSD.ORG Sun Dec 22 22:00:01 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 87DC4231 for ; Sun, 22 Dec 2013 22:00:01 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7421F1C81 for ; Sun, 22 Dec 2013 22:00:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rBMM00xO037716 for ; Sun, 22 Dec 2013 22:00:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rBMM00oB037715; Sun, 22 Dec 2013 22:00:00 GMT (envelope-from gnats) Date: Sun, 22 Dec 2013 22:00:00 GMT Message-Id: <201312222200.rBMM00oB037715@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Jilles Tjoelker Subject: Re: kern/185077: Sync L_cuserid with MAXLOGNAME X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Jilles Tjoelker List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Dec 2013 22:00:01 -0000 The following reply was made to PR kern/185077; it has been noted by GNATS. From: Jilles Tjoelker To: bug-followup@FreeBSD.org, naddy@FreeBSD.org Cc: Subject: Re: kern/185077: Sync L_cuserid with MAXLOGNAME Date: Sun, 22 Dec 2013 22:50:44 +0100 In PR kern/185077, you wrote: > L_cuserid must match MAXLOGNAME. When MAXLOGNAME was bumped to 33 in > , L_cuserid in was forgotten. > Fix: Bump L_cuserid to 33. Since cuserid() is only in libcompat which is only a static library, making this change does not break ABI. I still wonder whether it's worth it, though. What breaks if L_cuserid != MAXLOGNAME? They are different constants, so may have different values. This breakage should be weighed against the possible breakage resulting from changing things about cuserid() and L_cuserid, since they are obsolete APIs used by old crufty code. > Alternatively, for HEAD, consider completely removing cuserid(3) from > libcompat and L_cuserid with it. This is an option. It looks like cuserid() is mostly used by high-level languages to make it available to high-level language code. Parts of me, however, like the ability of compiling ancient source code, be it with -lcompat and other strange options. -- Jilles Tjoelker