From nobody Sat Aug 8 00:38:19 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hH2Dq58F3z6mYfS for ; Sat, 08 Aug 2026 00:38:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hH2Dq33RBz3mGD for ; Sat, 08 Aug 2026 00:38:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786149499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cQwL1TII+O8Tc+eDggFI3nCvWZ8w875slVW9oclMrZM=; b=fPRGoB7M90MR6Rb0iwFhd5p3I4T+Wy4xzJpsB4ut/B8kuJmAvg+u8cYW3S38dji2xWHH1Z ce8TeKDhFiPWwbHLUZ/C7tqoqHISVDY1+lf1+QRv949vAnj8IS7GUtD6pI2AxwCSdPRcDK CGFekfUzcFcHnYqbgmoI/+7OSjur6mMzAlJct/jNfvVBCj4xmJsybZe4EsQk3swyNZmJHv JGFyrf2FJ9DqfBtH+6sOWyCNURLwfmNHE7ST2ZMAHRcZ5HunvgdAZ+8l3g9bHHejjfctuv kPD5tSqF5Oefsbo2snQQRaYTNGgo7ppI0096ogeOaWXqzdKF9MaKGTW4ja/STA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786149499; a=rsa-sha256; cv=none; b=uvD1R8eDAA5Q58SdWHa4DZ5KC4BRYRi8H7rt9cH8UJayXtvBnJ9PAD4Sn3t6aknwbEEWZl buJsQQTr5RujY8fUXyKV9znNyPWrWu9pK/rgMxYAP4wwD4GIp+ltjIQ8QejF7ns23IlnLN WrUx1xwizpQHlaTfm7viDlfMeHgQL3dySkWEPv03m1aZuiUOGih+VPnGF88zyRTZXfMdsq 2qNglPCFwurbV65caM9QDct7+Lw4GrMSuCp1CuNezZHuhEIuo4UVCATMEKTC0vJm0Ussld i/fbAbroPx1XXBT3XQ6eCxea89dNxNdfKNSZKZgcl7dksxaTqLDKAdQhnwcePQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786149499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cQwL1TII+O8Tc+eDggFI3nCvWZ8w875slVW9oclMrZM=; b=tnmb/g8pKOYhahHwl9cEDd4MpBoty6irVIBBsA2WKJ8qx9LSntvCe1cakD/U3lPAWQw0Ux Drb1/H4fvDmkv2voucAl7Qdup80ExeCs2fnUmZn/4GfbWjlLoF1el80R6Yf9c0Gfkn9J8Y AbcqFc3UGAk1wrPZn0Y/me57oXXJI3EsSiI+ShGJdZcC0BKpydg8hZCSGMSr1J4Tlcnjzl h6VLmWY4E2YLyLkESTchpktZ/omrDNbNXHXleaW5/Rj6cwZLJdD/RHj8o9fTAg8X9oMb9M mvtErelTJjLrbGUO77F+OAqWgifJ9wM19+HGQA72n8nie9EuU6xp/roRvrDd+w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hH2Dq1TkmzdT for ; Sat, 08 Aug 2026 00:38:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3dd60 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 08 Aug 2026 00:38:19 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Daniil Iskhakov From: Kevin Bowling Subject: git: 44193b7f8e2f - stable/15 - ixgbe: avoid flow control counter overflow List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 44193b7f8e2f814c7777ca8bf7cdac62793011b3 Auto-Submitted: auto-generated Date: Sat, 08 Aug 2026 00:38:19 +0000 Message-Id: <6a767a7b.3dd60.24595d47@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=44193b7f8e2f814c7777ca8bf7cdac62793011b3 commit 44193b7f8e2f814c7777ca8bf7cdac62793011b3 Author: Daniil Iskhakov AuthorDate: 2026-07-28 11:07:33 +0000 Commit: Kevin Bowling CommitDate: 2026-08-08 00:35:16 +0000 ixgbe: avoid flow control counter overflow DPDK commit message net/ixgbe: fix flow control frame byte adjustment LXONTXC and LXOFFTXC are 32-bit counters for transmitted XON and XOFF packets. Their deltas are summed and used to adjust the transmitted packet and byte counters. Perform the addition in 64 bits so it cannot wrap before the result is used for the byte adjustment. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Daniil Iskhakov Acked-by: Bruce Richardson Obtained from: DPDK (bdf8608559) (cherry picked from commit 21e03ab39603fbab4bcef1dd61fe75e9e9276079) --- sys/dev/ixgbe/if_ix.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index 05448da71604..eb7e2ab00d3f 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -1871,9 +1871,9 @@ ixgbe_update_stats_counters(struct ixgbe_softc *sc) { struct ixgbe_hw *hw = &sc->hw; struct ixgbe_hw_stats *stats = &sc->stats.pf; - u32 missed_rx = 0, bprc, lxon, lxoff, total; + u32 missed_rx = 0, bprc, lxon, lxoff; u32 lxoffrxc; - u64 total_missed_rx = 0; + u64 total_missed_rx = 0, total; stats->crcerrs += IXGBE_READ_REG(hw, IXGBE_CRCERRS); stats->illerrc += IXGBE_READ_REG(hw, IXGBE_ILLERRC); @@ -1942,7 +1942,7 @@ ixgbe_update_stats_counters(struct ixgbe_softc *sc) stats->lxontxc += lxon; lxoff = IXGBE_READ_REG(hw, IXGBE_LXOFFTXC); stats->lxofftxc += lxoff; - total = lxon + lxoff; + total = (u64)lxon + lxoff; stats->gptc += IXGBE_READ_REG(hw, IXGBE_GPTC); stats->mptc += IXGBE_READ_REG(hw, IXGBE_MPTC);