Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 29 Nov 1998 15:16:19 -0500 (EST)
From:      Peter Philipp <pjp@bsd-daemon.net>
To:        ports@FreeBSD.ORG
Cc:        obrien@FreeBSD.ORG
Subject:   minicom port breaks at patch
Message-ID:  <Pine.BSF.4.01.9811291450140.22842-100000@bsd-daemon.net>

next in thread | raw e-mail | index | archive | help
I noticed minicom seems to be changed in the source minicom.c and the
patch patch-ae has outdated linenumbers.

<log on>

bsd-daemon# make
>> Checksum OK for minicom-1.80.src.tar.gz.
===>  Extracting for minicom-1.80
===>  Patching for minicom-1.80
===>  Applying FreeBSD patches for minicom-1.80
1 out of 1 hunks failed--saving rejects to minicom.c.rej
*** Error code 1

Stop.
*** Error code 1

Stop.
*** Error code 1

Stop.
bsd-daemon# uname -a
FreeBSD bsd-daemon.net 2.2.7-RELEASE FreeBSD 2.2.7-RELEASE #0: Wed Oct 14
15:13:14 EDT 1998     root@bsd-daemon.net:/usr/src/sys/compile/TAP  i386
bsd-daemon# cd work/minicom*80/src
bsd-daemon# more minicom.c.rej
***************
*** 530,536 ****
      /* Loop again if more options */
    } while(optind < argk);

-   if (real_uid == 0 && dosetup == 0) {
        fprintf(stderr, "%s%s%s",
    "minicom: WARNING: please don't run minicom as root when not
maintaining\n",
    "                  it (with the -s switch) since all changes to
the\n",
--- 530,537 ----
      /* Loop again if more options */
    } while(optind < argk);

+   /* also allow root to run minicom with `-d' switch */
+   if (real_uid == 0 && dosetup == 0 && cmd_dial == NULL) {
        fprintf(stderr, "%s%s%s",
    "minicom: WARNING: please don't run minicom as root when not
maintaining\n",
    "                  it (with the -s switch) since all changes to
the\n",


</log off>


The contents of the specific lines for the patch are around line 897 of
minicom.c and are commented out.  

line 897 of minicom.c

/*
 * if (real_uid == 0 && dosetup == 0) {
 *      fprintf(stderr, "%s%s%s",
 *  "minicom: WARNING: please don't run minicom as root when not
maintaining\n",
 *  "                  it (with the -s switch) since all changes to
the\n",
 *  "                  configuration will be GLOBAL !.\n");
 *      sleep(5);
 * }
*/

 
removing patch-ae seems to be a workaround.  After removing patch and make
install:

...
===>   Compressing manual pages for minicom-1.80
===>  Registering installation for minicom-1.80


Peter Philipp (PP2441)
Daemonic Networks
"In theory, theory is the same as practice, but not in practice" - ???



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.01.9811291450140.22842-100000>