From owner-freebsd-net@FreeBSD.ORG  Sat May 30 08:50:03 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 49223106566C
	for <freebsd-net@hub.freebsd.org>; Sat, 30 May 2009 08:50:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 371D58FC23
	for <freebsd-net@hub.freebsd.org>; Sat, 30 May 2009 08:50:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n4U8o3ld024704
	for <freebsd-net@freefall.freebsd.org>; Sat, 30 May 2009 08:50:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n4U8o3mq024703;
	Sat, 30 May 2009 08:50:03 GMT (envelope-from gnats)
Date: Sat, 30 May 2009 08:50:03 GMT
Message-Id: <200905300850.n4U8o3mq024703@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: Mateusz Guzik <mjguzik@gmail.com>
Cc: 
Subject: Re: kern/135067: [patch] [fib] Incorrect KASSERTs in sys/net/route.c
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Mateusz Guzik <mjguzik@gmail.com>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 30 May 2009 08:50:03 -0000

The following reply was made to PR kern/135067; it has been noted by GNATS.

From: Mateusz Guzik <mjguzik@gmail.com>
To: Julian Elischer <julian@elischer.org>
Cc: bug-followup@freebsd.org
Subject: Re: kern/135067: [patch] [fib] Incorrect KASSERTs in sys/net/route.c
Date: Sat, 30 May 2009 10:42:25 +0200

 On Sat, May 30, 2009 at 3:58 AM, Julian Elischer <julian@elischer.org> wrot=
 e:
 > if you have 16 fibs then valid values are 0,1,2,.....14,15
 >
 > if fibnum =3D=3D rt_numfibs then that is an error.
 >
 > thus in setfib... if uap->numfbs is 16 OR GREATER =A0it is and EINVAL
 >
 > and the kasserts in route.c need to check that fibnum is =A0LESS THAN
 > rt_numfibs.
 >
 
 That's correct.
 
 >
 > what makes you think there is an error?
 >
 
 I somehow misread that KASSERT as triggered only when fibnum >
 rt_numfibs. I guess it was too late at night. :) Sorry for the noise.
 
 --
 Mateusz Guzik <mjguzik at gmail.com>