From owner-cvs-all Sun Dec 2 16:53:10 2001 Delivered-To: cvs-all@freebsd.org Received: from mail11.speakeasy.net (mail11.speakeasy.net [216.254.0.211]) by hub.freebsd.org (Postfix) with ESMTP id ADC8237B41A for ; Sun, 2 Dec 2001 16:52:56 -0800 (PST) Received: (qmail 11006 invoked from network); 3 Dec 2001 00:53:40 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail11.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 3 Dec 2001 00:53:40 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20011202212827.D36916@skriver.dk> Date: Sun, 02 Dec 2001 16:52:54 -0800 (PST) From: John Baldwin To: Jesper Skriver Subject: Re: cvs commit: CVSROOT cfg.pm log_accum.pl Cc: Josef Karthauser , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Mike Barcroft Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 02-Dec-01 Jesper Skriver wrote: > On Sat, Dec 01, 2001 at 07:55:15PM -0800, John Baldwin wrote: >> >> On 02-Dec-01 Mike Barcroft wrote: >> > Josef Karthauser writes: >> >> joe 2001/12/01 03:38:44 PST >> >> >> >> Modified files: >> >> . cfg.pm log_accum.pl >> >> Log: >> >> Add the ability to have diffs inserted into the commit email. >> >> >> >> Submitted by: jesper >> >> >> >> Revision Changes Path >> >> 1.44 +5 -2 CVSROOT/cfg.pm >> >> 1.114 +73 -0 CVSROOT/log_accum.pl >> > >> > cvs-verbose@FreeBSD.org anyone? This would lower the barrier to entry >> > for reviewing commits. >> >> Does it limit the length? p4 submit mails trim the output at 1000 lines. >> Otherwise imports of vendor software could be some _very_ large e-mails. :) > > The variable which enable it, it a size limiter, if you set i to 1, the > diff of a given file will only be shown if it's less than 1 kbyte ... It doesn't omit the entire diff if it's too long, it makes the diff and then after the first 1000 lines, it truncates the diff adn prints a "diff truncated at 1000 lines for mail" line (or something like that.) Slightly different thing. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message