From owner-svn-src-head@freebsd.org Sun Sep 11 16:50:36 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3EC6DBD6750; Sun, 11 Sep 2016 16:50:36 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F0130C38; Sun, 11 Sep 2016 16:50:35 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from [10.1.1.2] (unknown [10.1.1.2]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id 5DAE31805; Sun, 11 Sep 2016 16:50:29 +0000 (UTC) Subject: Re: svn commit: r304815 - in head: lib lib/libifc share/examples/libifc share/mk To: Baptiste Daroussin , Kristof Provost , Marie Helene Kvello-Aune References: <201608251940.u7PJePv3023083@repo.freebsd.org> <20160911144955.3s5cjd22li7xdcal@ivaldir.etoilebsd.net> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Allan Jude Message-ID: <9855ae5e-1c9a-caea-9b1a-cfda5ece7258@freebsd.org> Date: Sun, 11 Sep 2016 12:50:25 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160911144955.3s5cjd22li7xdcal@ivaldir.etoilebsd.net> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oR7ucqnWJOgl8bjxaspF0VIabVcTl7A6a" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2016 16:50:36 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oR7ucqnWJOgl8bjxaspF0VIabVcTl7A6a Content-Type: multipart/mixed; boundary="280LnlS3ljOLR7Etg31k37Q9XV4wOv1q0" From: Allan Jude To: Baptiste Daroussin , Kristof Provost , Marie Helene Kvello-Aune Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <9855ae5e-1c9a-caea-9b1a-cfda5ece7258@freebsd.org> Subject: Re: svn commit: r304815 - in head: lib lib/libifc share/examples/libifc share/mk References: <201608251940.u7PJePv3023083@repo.freebsd.org> <20160911144955.3s5cjd22li7xdcal@ivaldir.etoilebsd.net> In-Reply-To: <20160911144955.3s5cjd22li7xdcal@ivaldir.etoilebsd.net> --280LnlS3ljOLR7Etg31k37Q9XV4wOv1q0 Content-Type: multipart/mixed; boundary="------------F8B125D0689F1485C3EC70CA" This is a multi-part message in MIME format. --------------F8B125D0689F1485C3EC70CA Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2016-09-11 10:49, Baptiste Daroussin wrote: > On Thu, Aug 25, 2016 at 07:40:25PM +0000, Kristof Provost wrote: >> Author: kp >> Date: Thu Aug 25 19:40:25 2016 >> New Revision: 304815 >> URL: https://svnweb.freebsd.org/changeset/base/304815 >> >> Log: >> Add libifc, a library implementing core functionality that exists in= ifconfig(8) today. >> =20 >> libifc (pronounced lib-ifconfig) aims to be a light abstraction laye= r between >> programs and the kernel APIs for managing the network configuration.= >> This should hopefully make programs easier to maintain, and reduce c= ode >> duplication. >> =20 >> Work will begin on making ifconfig(8) use this library in the near f= uture. >> =20 >> This code is still evolving. The interface should not be considered = stable until >> it is announced as such. >> =20 >=20 > Sorry I come to this very late but: >=20 > If it is not stable yet, it would probably be a good idea to make it a > privatelib, so even if we end up shipping a release with the lib before= > considered stable we are safe updating it? >=20 > It won't prevent any usage one can imagine in base. >=20 > The private flag can be dropped once it is considered stable >=20 > Best regards, > Bapt >=20 That is a good idea, and is just a one line change: --=20 Allan Jude --------------F8B125D0689F1485C3EC70CA Content-Type: text/plain; charset=UTF-8; name="libifconfig_private.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="libifconfig_private.diff" Index: lib/libifconfig/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- lib/libifconfig/Makefile (revision 305635) +++ lib/libifconfig/Makefile (working copy) @@ -2,6 +2,7 @@ =20 PACKAGE=3D lib${LIB} LIB=3D ifconfig +PRIVATELIB=3D true # Don't build shared library, for now. NO_PIC=3D=20 =20 --------------F8B125D0689F1485C3EC70CA-- --280LnlS3ljOLR7Etg31k37Q9XV4wOv1q0-- --oR7ucqnWJOgl8bjxaspF0VIabVcTl7A6a Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJX1YtUAAoJEBmVNT4SmAt+MwUQAJQVr0Zy8Qc3XhJAk4z/fVGt 6bVRYtsQ9cVrxIX4I7doz1bF1iOqcbzQIAfrPoI3zPBEz2Qc60iCaUHu92nP/ggO b/kE59R5KidnE4kh5zCCbtE4GBwf+HjaM19V03/pWS+nYoAM9enSwrPi+gv14R/I w/i6pYTqgSTyit23RouX32PpFxtc7fp9TstuCQjXXjJN0JtEsT60Y+7oAKtu2UbF vlPjSnkOxgotBgUkf7WMTvHoGpifvsMOjgNklYiZVamRxWSVrQSEKiXNbySuMgyJ 5R0FgXL5riuVtgvJIA9dIaIo+moxz6cZFhBgbQxYzzSEVNsmczu3+hHcW0n7n77Q 2z4ypQGW1cuh9/H8Qx2j+USksbvC7Sj1yPwXaqgVmOx/c/Q+W+t/muTP/qTmRhjX YfXf3G1a3hQ6iycTmAj3mI8Dx/DAG7SK0EPxnWnmLgDClNd0uO0HR4F+qCLMg8rJ EhgSnfQ0smvY2ZDTwnGbfxI4MbV0Vurm1x0URxsrpZCFymHQF4pWOcdXn+/gL9sf 80z9jj/e1dmpiaJ9Ch5gDbnSE2d5xU+kpd61rfyrUIWMxwReAufPSbmJ5kjgcyHf N2ELj06OSzlte889XBTXZTVP2SpsAUg55D2BsXN0KE0pYX3IpUURdO/YPgnXeY6e ajRTNDyNydw6mZXVS5g2 =Cphj -----END PGP SIGNATURE----- --oR7ucqnWJOgl8bjxaspF0VIabVcTl7A6a--