From owner-cvs-src@FreeBSD.ORG Mon Oct 4 23:43:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1CC7416A4CE; Mon, 4 Oct 2004 23:43:56 +0000 (GMT) Received: from blackwater.lemis.com (wantadilla.lemis.com [192.109.197.135]) by mx1.FreeBSD.org (Postfix) with ESMTP id D1E9D43D45; Mon, 4 Oct 2004 23:43:54 +0000 (GMT) (envelope-from grog@lemis.com) Received: by blackwater.lemis.com (Postfix, from userid 1004) id CCBC285612; Tue, 5 Oct 2004 09:13:51 +0930 (CST) Date: Tue, 5 Oct 2004 09:13:51 +0930 From: Greg 'groggy' Lehey To: "M. Warner Losh" Message-ID: <20041004234351.GD75289@wantadilla.lemis.com> References: <200410041313.i94DDN1w064795@repoman.freebsd.org> <20041004.095538.105191591.imp@bsdimp.com> <20041004223426.GJ460@wantadilla.lemis.com> <20041004.163808.73381384.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="11Y7aswkeuHtSBEs" Content-Disposition: inline In-Reply-To: <20041004.163808.73381384.imp@bsdimp.com> User-Agent: Mutt/1.4.2.1i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: phk@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_shutdown.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Oct 2004 23:43:56 -0000 --11Y7aswkeuHtSBEs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Monday, 4 October 2004 at 16:38:08 -0600, M. Warner Losh wrote: > In message: <20041004223426.GJ460@wantadilla.lemis.com> > "Greg 'groggy' Lehey" writes: >> On Monday, 4 October 2004 at 9:55:38 -0600, M. Warner Losh wrote: >>> In message: <200410041313.i94DDN1w064795@repoman.freebsd.org> >>> Poul-Henning Kamp writes: >>>> phk 2004-10-04 13:13:23 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sys/kern kern_shutdown.c >>>> Log: >>>> Change the perfectly precise message >>>> printf("No buffers busy after final sync"); >>>> to >>>> printf("All buffers synced."); >>>> in order to not leave the users wondering if there should be. >>> >>> Any not reason to delete >>> printf("All buffers synced."); >>> entirely? >> >> I like to see some message to confirm that the process is over and >> done with. Something goes wrong often enough that it's good to know >> that it worked this time. > > The machine will either shutoff, reboot or print the 'hit any key to > reboot' message in addition. ... assuming everything works correctly. > Do we really need an additional message saying that we did the right > thing? No. If it always works, that's fine. I've had too many cases where it didn't, though. I can't see that it does any harm to state the fact. Greg -- See complete headers for address and phone numbers. --11Y7aswkeuHtSBEs Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBYeA3IubykFB6QiMRAsrrAJ9HEf461RLx2+Ucw0W+gWFw2oKXjgCcCdCd FA8VDNNTixC2Tf0a66+uXWQ= =15FM -----END PGP SIGNATURE----- --11Y7aswkeuHtSBEs--