From owner-svn-ports-all@FreeBSD.ORG Wed Sep 25 14:15:40 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 5095BBEA; Wed, 25 Sep 2013 14:15:40 +0000 (UTC) (envelope-from bsam@passap.ru) Received: from forward14.mail.yandex.net (forward14.mail.yandex.net [IPv6:2a02:6b8:0:801::4]) by mx1.freebsd.org (Postfix) with ESMTP id 029A728F1; Wed, 25 Sep 2013 14:15:40 +0000 (UTC) Received: from smtp11.mail.yandex.net (smtp11.mail.yandex.net [95.108.130.67]) by forward14.mail.yandex.net (Yandex) with ESMTP id 779A81982B0C; Wed, 25 Sep 2013 18:15:35 +0400 (MSK) Received: from smtp11.mail.yandex.net (localhost [127.0.0.1]) by smtp11.mail.yandex.net (Yandex) with ESMTP id 0DDFF7E0556; Wed, 25 Sep 2013 18:15:34 +0400 (MSK) Received: from 87.249.28.58.tel.ru (87.249.28.58.tel.ru [87.249.28.58]) by smtp11.mail.yandex.net (nwsmtp/Yandex) with ESMTP id vaknW2EyEx-FYeWKVqK; Wed, 25 Sep 2013 18:15:34 +0400 Message-ID: <5242F005.3010303@passap.ru> Date: Wed, 25 Sep 2013 18:15:33 +0400 From: Boris Samorodov User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130811 Thunderbird/17.0.8 MIME-Version: 1.0 To: William Grzybowski Subject: Re: svn commit: r328268 - head/www/zend-framework References: <201309251128.r8PBShhM020984@svn.freebsd.org> In-Reply-To: <201309251128.r8PBShhM020984@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Wed, 25 Sep 2013 15:50:34 +0000 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Sep 2013 14:15:40 -0000 Hi William and All, just a random pickup of the commit. 25.09.2013 15:28, William Grzybowski пишет: > .if ${PORT_OPTIONS:MDOCS} > - @${MKDIR} ${DOCSDIR} > - ${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${DOCSDIR}/ > + @${MKDIR} ${STAGEDIR}${DOCSDIR} > + ${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}/ > .endif If I understand staging correctly, those ".if ..." and ".endif" lines may be removed as well: a) with staging the role of pkg-plist has changed greatly. Before staging an ordinary (with just a filename) line at pkg-plist meant that a file _should_ be installed. With staging that line defines that the file _will_ be installed (i.e. pkg-plist is the source of what to install); b) real install to PREFIX will not contain all files installed at STAGEDIR but only those listed at pkg-plist modulo %%VARIOUS_DEFINES%%. So if PORT_OPTIONS:MDOCS is not defined those files with %%PORTDOCS%% will not be installed to the system (however they will appear at the STAGEDIR). In short: if you omit those if-endif checks then PORTDOCS would be always copied to STAGEDIR. But they would be installed to real system only if PORT_OPTIONS:MDOCS is defined. Disclaimer: I can't say anything about system performance impact of having/not having those checks at a Makefile. So in the end it may be just a matter of taste... until we have a policy on this. -- WBR, Boris Samorodov (bsam) FreeBSD Committer, http://www.FreeBSD.org The Power To Serve