From owner-freebsd-xfce@freebsd.org Tue Nov 28 15:15:08 2017 Return-Path: Delivered-To: freebsd-xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E6B12DB917D for ; Tue, 28 Nov 2017 15:15:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id CD5D4681E9 for ; Tue, 28 Nov 2017 15:15:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id CCBCDDB917C; Tue, 28 Nov 2017 15:15:08 +0000 (UTC) Delivered-To: xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CC661DB917B for ; Tue, 28 Nov 2017 15:15:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BA3F7681E8 for ; Tue, 28 Nov 2017 15:15:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vASFF8gc012408 for ; Tue, 28 Nov 2017 15:15:08 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 202192] [PATCH] x11-fm/thunar 1.6.11 change file permissions on sshfs mounted files/dirs Date: Tue, 28 Nov 2017 15:15:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: rozhuk.im@gmail.com X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xfce@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 15:15:09 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202192 --- Comment #4 from rozhuk.im@gmail.com --- IMHO they dont try build without HAVE_GIO_UNIX: GDesktopAppInfo is part of = gio and hey will get undefined struct/type compiler error. They patch does not work (without mine) - 100%. Upstream do many insane and crappy things, I dont want understand why :) I replace effective_user_id =3D=3D g_file_info_get_attribute_uint32 (file->info, G_FILE_ATTRIBUTE_UNIX_UID) to thunar_file_is_writable(file) All other logic not changed, just refactored to human understanding. You can use both checks via ||, like: return (effective_user_id =3D=3D g_file_info_get_attribute_uint32 (file->in= fo, G_FILE_ATTRIBUTE_UNIX_UID) || thunar_file_is_writable(file)) May be in some cases there different access levels for file data and metada= ta and original code will return TRUE is user is file owner or root. I dont know what use cases this cover, probably none. My check is simple: if file writeable than we can write metadata. This is good for most cases. I dont know how to allow user write data and restrict write metadata in unix with chmod(). In my case sshfs mounted to me (simple user), by authorized on remote side = as root. --=20 You are receiving this mail because: You are the assignee for the bug.=