Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Aug 2021 23:11:08 GMT
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 9339e7c0bd56 - main - rtsx: Fix wakeup race similar to sdhci one fixed in 35547df5c786
Message-ID:  <202108102311.17ANB87E063500@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=9339e7c0bd565506092bb0a2618ff32fb04bb2c4

commit 9339e7c0bd565506092bb0a2618ff32fb04bb2c4
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2021-08-10 23:07:50 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2021-08-10 23:10:25 +0000

    rtsx: Fix wakeup race similar to sdhci one fixed in 35547df5c786
    
    rtsx copied code from sdhci, and has the same wakeup race bug that was
    fixed in 35547df5c786, so apply a similar fix here.
    
    Sponsored by:           Netflix
---
 sys/dev/rtsx/rtsx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/rtsx/rtsx.c b/sys/dev/rtsx/rtsx.c
index 4400fbef5412..cb85685c875c 100644
--- a/sys/dev/rtsx/rtsx.c
+++ b/sys/dev/rtsx/rtsx.c
@@ -3532,8 +3532,8 @@ rtsx_mmcbr_release_host(device_t bus, device_t child __unused)
 	sc = device_get_softc(bus);
 	RTSX_LOCK(sc);
 	sc->rtsx_bus_busy--;
-	RTSX_UNLOCK(sc);
 	wakeup(&sc->rtsx_bus_busy);
+	RTSX_UNLOCK(sc);
 
 	return (0);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202108102311.17ANB87E063500>