Date: Mon, 9 May 2016 11:50:42 +0900 From: Ganbold Tsagaankhuu <ganbold@gmail.com> To: Kurt Jaeger <lists@opsec.eu> Cc: freebsd-ports@freebsd.org Subject: Re: new port for review: LDAP Authenticator plugin for MySQL Message-ID: <CAGtf9xManm8fQevjTr%2BHKxqhh8v-HHWdR8yA2ux=oypVjkZBTA@mail.gmail.com> In-Reply-To: <CAGtf9xOLddVZOxCQs7JbpAATq%2BcTib7HmbHdr6vARuykp-uNMQ@mail.gmail.com> References: <CAGtf9xOtVGoWsLds3srJEyu9RenDfoYONw4yNJB%2Bgr_T6G5_YA@mail.gmail.com> <20160507070925.GA2295@home.opsec.eu> <CAGtf9xOLddVZOxCQs7JbpAATq%2BcTib7HmbHdr6vARuykp-uNMQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, On Sun, May 8, 2016 at 12:28 PM, Ganbold Tsagaankhuu <ganbold@gmail.com> wrote: > Hi, > > On Sat, May 7, 2016 at 4:09 PM, Kurt Jaeger <lists@opsec.eu> wrote: > >> Hi! >> >> > Can anyone take a look or review new port at >> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208913 ? >> > This is LDAP Authenticator plugin for MySQL. >> >> One important thing: new ports should be submitted as shar-file. >> >> There are several issues, which running >> >> cd <port> >> portlint -AC >> >> flags. > > > > In my case portent -AC shows "pkg-descr: exceeds 24 lines, make it shorter > if possible.(currently 39 lines)" > I will fix that. > Uploaded modified shar file: https://bz-attachments.freebsd.org/attachment.cgi?id=170111 thanks, Ganbold > > > >> One other thing that sticks out: Is it really necessary to have >> the ateam prefix for the port ? >> > > > Yes, we can't remove the A-Team part because then the project name is > basically the same as the project we forked. We need it there to > differentiate. > > > >> >> I've added a shar of the modified port to the PR, which still >> does not yet fetch and build. Can you provide a version 1.0 >> on github that we can fetch ? >> > > > Should it necessarily does have version 1.0 in github? Can't it > use GH_TAGNAME ? > > thanks, > > Ganbold > > > >> >> Btw, I've created the shar with: >> >> shar `find mysql-ldap-auth -print` > /tmp/ldap.shar >> >> -- >> pi@opsec.eu +49 171 3101372 4 years >> to go ! >> > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGtf9xManm8fQevjTr%2BHKxqhh8v-HHWdR8yA2ux=oypVjkZBTA>