From owner-freebsd-current  Tue Aug 29  4:19:30 2000
Delivered-To: freebsd-current@freebsd.org
Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4667737B440; Tue, 29 Aug 2000 04:19:26 -0700 (PDT)
Received: (from ache@localhost)
	by nagual.pp.ru (8.11.0/8.11.0) id e7TBJ4R90522;
	Tue, 29 Aug 2000 15:19:04 +0400 (MSD)
	(envelope-from ache)
Date: Tue, 29 Aug 2000 15:19:00 +0400
From: "Andrey A. Chernov" <ache@nagual.pp.ru>
To: Alexey Zelkin <phantom@cris.crimea.ua>
Cc: i18n@FreeBSD.ORG, current@FreeBSD.ORG
Subject: Re: Request for review: locale aliases support for libc
Message-ID: <20000829151857.A90464@nagual.pp.ru>
References: <20000829140102.A29555@ark.cris.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20000829140102.A29555@ark.cris.net>; from phantom@cris.crimea.ua on Tue, Aug 29, 2000 at 02:01:02PM +0300
Organization: Biomechanoid
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Tue, Aug 29, 2000 at 02:01:02PM +0300, Alexey Zelkin wrote:
> please review and comment

By quick looking I found this:

1) strtok() should not be used in libraries, use strsep() instead.

2) There is security hole with LOCALE_ALIASES_PATH env. issetugid() check
required.

3) The same functionality should be added to NLS (catgets() etc.) to make
it really working.


-- 
Andrey A. Chernov
<ache@nagual.pp.ru>
http://ache.pp.ru/


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message