From owner-freebsd-isp Tue Jul 17 12:45:53 2001 Delivered-To: freebsd-isp@freebsd.org Received: from phoenix.volant.org (dickson.phoenix.volant.org [205.179.79.193]) by hub.freebsd.org (Postfix) with ESMTP id CD5F337B40C for ; Tue, 17 Jul 2001 12:45:49 -0700 (PDT) (envelope-from patl@phoenix.volant.org) Received: from asimov.phoenix.volant.org ([205.179.79.65] helo=asimov) by phoenix.volant.org with esmtp (Exim 1.92 #8) id 15Mamv-0004tt-00; Tue, 17 Jul 2001 12:45:45 -0700 Date: Tue, 17 Jul 2001 12:45:45 -0700 From: PM Lashley To: Alexey Zakirov Cc: freebsd-isp@FreeBSD.ORG Subject: Re: jail Message-ID: <621390000.995399145@asimov> In-Reply-To: References: X-Mailer: Mulberry/2.1.0b2 (SunOS/SPARC Demo) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Sender: owner-freebsd-isp@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --On Tuesday, July 17, 2001 23:29:12 +0400 Alexey Zakirov wrote: > On Tue, 17 Jul 2001, PM Lashley wrote: > >> Yes, I have. Note that my solution still uses xargs to get around the >> command-line buffer size restrictions. It just eliminates the 'cat' in >> favor of redirecting stdin for xargs. >> >> Yours: cat FOO | xargs CMD >> Mine: xargs CMD < FOO >> >> It eliminates the unnecessary and unhelpful cat process, it's buffers, >> the pipe, etc. >> >> The construct 'cat ONE-FILE |' can almost always be replaced by a stdin > > Sorry but this is doesn't matter for jail solution. No one aware about > updating jails. I'm make it about 2 times per month but not so care. In > the real life users most interested in the things like GD perl library not > the system /usr/sbin/faithd one. :) It's a matter of cultivating good practices. (That's why I called it a 'nit' in my first posting.) In this situation, it doesn't really matter very much whether there's an extra 'cat' or not. BUT it is better to simply cultivate the habit of avoiding such constructs so that you won't use them where they do matter. AND the code fragment was being ezplicitly listed as an example to a less experienced admin. Examples should -ALWAYS- use the best practices. (Unless they are explicitly examples of bad practices...) -Pat To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-isp" in the body of the message