From owner-svn-src-user@freebsd.org Wed Feb 3 02:14:32 2016 Return-Path: <owner-svn-src-user@freebsd.org> Delivered-To: svn-src-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E7591A9A45B for <svn-src-user@mailman.ysv.freebsd.org>; Wed, 3 Feb 2016 02:14:32 +0000 (UTC) (envelope-from ngie@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B53901733; Wed, 3 Feb 2016 02:14:32 +0000 (UTC) (envelope-from ngie@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u132EVfV057898; Wed, 3 Feb 2016 02:14:31 GMT (envelope-from ngie@FreeBSD.org) Received: (from ngie@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u132EVqY057897; Wed, 3 Feb 2016 02:14:31 GMT (envelope-from ngie@FreeBSD.org) Message-Id: <201602030214.u132EVqY057897@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: ngie set sender to ngie@FreeBSD.org using -f From: Garrett Cooper <ngie@FreeBSD.org> Date: Wed, 3 Feb 2016 02:14:31 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r295193 - user/ngie/bsnmp_cleanup/contrib/bsnmp/snmp_mibII X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" <svn-src-user.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-user>, <mailto:svn-src-user-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user/> List-Post: <mailto:svn-src-user@freebsd.org> List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-user>, <mailto:svn-src-user-request@freebsd.org?subject=subscribe> X-List-Received-Date: Wed, 03 Feb 2016 02:14:33 -0000 Author: ngie Date: Wed Feb 3 02:14:31 2016 New Revision: 295193 URL: https://svnweb.freebsd.org/changeset/base/295193 Log: Return `ret` in op_ifentry(..) to mute a -Wunused-but-set-variable warning This should also now undetected error conditions with value->var.subs[sub - 1] == LEAF_ifPhysAddress where `string_get(..)` could fail if iifp->physaddr and/or iifp->physaddrlen were deemed invalid. Reported by: Jenkins (clang job) [1], Jenkins (gcc 4.9 job) [2] Sponsored by: EMC / Isilon Storage Division Modified: user/ngie/bsnmp_cleanup/contrib/bsnmp/snmp_mibII/mibII_interfaces.c Modified: user/ngie/bsnmp_cleanup/contrib/bsnmp/snmp_mibII/mibII_interfaces.c ============================================================================== --- user/ngie/bsnmp_cleanup/contrib/bsnmp/snmp_mibII/mibII_interfaces.c Wed Feb 3 02:08:55 2016 (r295192) +++ user/ngie/bsnmp_cleanup/contrib/bsnmp/snmp_mibII/mibII_interfaces.c Wed Feb 3 02:14:31 2016 (r295193) @@ -356,7 +356,7 @@ op_ifentry(struct snmp_context *ctx, str value->v.oid = ifp->spec_oid; break; } - return (SNMP_ERR_NOERROR); + return (ret); } /*