From owner-p4-projects@FreeBSD.ORG  Sun Dec 30 13:53:17 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 7B50B16A46B; Sun, 30 Dec 2007 13:53:17 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3B51F16A41B
	for <perforce@FreeBSD.org>; Sun, 30 Dec 2007 13:53:17 +0000 (UTC)
	(envelope-from hselasky@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 29F5813C4EF
	for <perforce@FreeBSD.org>; Sun, 30 Dec 2007 13:53:17 +0000 (UTC)
	(envelope-from hselasky@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id lBUDrHFv073454
	for <perforce@FreeBSD.org>; Sun, 30 Dec 2007 13:53:17 GMT
	(envelope-from hselasky@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id lBUDrHxK073450
	for perforce@freebsd.org; Sun, 30 Dec 2007 13:53:17 GMT
	(envelope-from hselasky@FreeBSD.org)
Date: Sun, 30 Dec 2007 13:53:17 GMT
Message-Id: <200712301353.lBUDrHxK073450@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	hselasky@FreeBSD.org using -f
From: Hans Petter Selasky <hselasky@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 132095 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Dec 2007 13:53:17 -0000

http://perforce.freebsd.org/chv.cgi?CH=132095

Change 132095 by hselasky@hselasky_laptop001 on 2007/12/30 13:53:16

	
	Get rid if inlining. These functions are not time critical.

Affected files ...

.. //depot/projects/usb/src/sys/dev/usb/uchcom.c#5 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/usb/uchcom.c#5 (text+ko) ====

@@ -398,7 +398,7 @@
  * low level i/o
  */
 
-static __inline usbd_status
+static usbd_status
 uchcom_ctrl_write(struct uchcom_softc *sc, uint8_t reqno,
 		    uint16_t value, uint16_t index)
 {
@@ -413,7 +413,7 @@
 	return usbd_do_request(sc->sc_ucom.sc_udev, &req, 0);
 }
 
-static __inline usbd_status
+static usbd_status
 uchcom_ctrl_read(struct uchcom_softc *sc, uint8_t reqno,
 		   uint16_t value, uint16_t index, void *buf, int buflen,
 		   int *actlen)
@@ -431,7 +431,7 @@
 				     USBD_DEFAULT_TIMEOUT);
 }
 
-static __inline usbd_status
+static usbd_status
 uchcom_write_reg(struct uchcom_softc *sc,
 	  uint8_t reg1, uint8_t val1, uint8_t reg2, uint8_t val2)
 {
@@ -443,7 +443,7 @@
 		reg1|((uint16_t)reg2<<8), val1|((uint16_t)val2<<8));
 }
 
-static __inline usbd_status
+static usbd_status
 uchcom_read_reg(struct uchcom_softc *sc,
 	 uint8_t reg1, uint8_t *rval1, uint8_t reg2, uint8_t *rval2)
 {
@@ -467,7 +467,7 @@
 	return USBD_NORMAL_COMPLETION;
 }
 
-static __inline usbd_status
+static usbd_status
 get_version(struct uchcom_softc *sc, uint8_t *rver)
 {
 	uint8_t buf[UCHCOM_INPUT_BUF_SIZE];
@@ -484,19 +484,19 @@
 	return USBD_NORMAL_COMPLETION;
 }
 
-static __inline usbd_status
+static usbd_status
 uchcom_get_status(struct uchcom_softc *sc, uint8_t *rval)
 {
 	return uchcom_read_reg(sc, UCHCOM_REG_STAT1, rval, UCHCOM_REG_STAT2, NULL);
 }
 
-static __inline usbd_status
+static usbd_status
 uchcom_set_dtrrts_10(struct uchcom_softc *sc, uint8_t val)
 {
 	return uchcom_write_reg(sc, UCHCOM_REG_STAT1, val, UCHCOM_REG_STAT1, val);
 }
 
-static __inline usbd_status
+static usbd_status
 uchcom_set_dtrrts_20(struct uchcom_softc *sc, uint8_t val)
 {
 	return uchcom_ctrl_write(sc, UCHCOM_REQ_SET_DTRRTS, val, 0);