From nobody Wed Feb 25 01:24:05 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fLH1L1gxJz6TVJK; Wed, 25 Feb 2026 01:24:06 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fLH1L03Qsz3Vm4; Wed, 25 Feb 2026 01:24:06 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771982646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jP7ztwe26VZ2jvmvFaOP9fAmrWLOpBeq24VI27hIbsk=; b=i933i4WiCspUtXsPe7nSAb0fQR6Vqp/+U8B6NHvkRWUSz3KQSCNY4QPRaSitaq5s7eofMk OvoHw+aHvI1Zt2JhTXhiwF9USXfSRWhEPK0Ku0sbB5VX8YMBBtlbeDvbA7lnZmT2qtVfjf fXVsebgMpKnTVl6sO8Mzs7yNJQsLDjFfdo2PINjf4jv5Dzpo/0ygH8aW1e8fEU2HNtirVh CvkeLSVe2fpSmPAytjfcawRBhXKBizqP1a/Xaf95QzmNLO9qfUz1WxWX0PlhQ0CpiCZaVb 5TvzPtXNOVieKDnltv9Rx/N4sBo67wo6k7L/F+NMws7N9VBCGFEJb8oqo756EQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771982646; a=rsa-sha256; cv=none; b=mWB/Hv31kATJP1vZas3aS6o0wChCn3oVIo8hk4u51DiaY6AwUPoFv+r7aJKm6sGBQ7tP0M kJZ2A4l0G0RRENmldZjAJjG/FmbT/cXiobtugLQ6Gxb9M5il5n7Y5kdRew408HDaStpNTh rnJ9U4dUtd89L4Qcs5XNaCsVWxxu91XzPXL3ZwkiiXNPJ+c2CBpY4WXGye7iK3RgN4J9AG L3h5fHihG38GaJWHv9GkHXK1If6oM/k3M8z7P8qnMq4fdU7N0h2K5NI3r+xt+WrNVMr2op DVbpQwsGYYdDJn9/QsaK405tdGuuq4P9lhGwjTPQTQbh3edxPiVXkt9KOgNYAw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771982646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jP7ztwe26VZ2jvmvFaOP9fAmrWLOpBeq24VI27hIbsk=; b=aQanWda1iQIXXafqTNYa8ZE3X7WZSYbyVfbTFWe7WC7j3XMouN3VJ6jFlCWlVIVgPxR4/j KmyG9vuNuJuAIdfmM5qol3cxTDUy08cv7VO5elSUQoguuHBsvEpOIq+gm8sNOCkBXd714P zjhXkIrRe6MEyYXzoXG9SlHVcekJyRzbQepOV8u8TsiZSeOagr48lzie8HDftUnQ4q7w4l X6uClyuHky80TutFlmM3zwYIkawcwup3bbOYzcXGmVvwWkGzAwJODW4vIHVZcGewlg1sa7 EU8800hvHp2HlZAesPfF92kWAQE8W0jyn3mWIFvxMLOVy6HpudIdfXhubMGcIw== Received: from [IPV6:2601:5c0:4202:5670:b946:cabf:47b1:71cf] (unknown [IPv6:2601:5c0:4202:5670:b946:cabf:47b1:71cf]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fLH1K5Fn1z148w; Wed, 25 Feb 2026 01:24:05 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Tue, 24 Feb 2026 20:24:05 -0500 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 5edf24aac1d0 - main - ofed: reduce usage of struct dma_attrs *dma_attrs Content-Language: en-US To: "Bjoern A. Zeeb" , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <699e2185.37782.5dbfa03b@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <699e2185.37782.5dbfa03b@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/24/26 17:09, Bjoern A. Zeeb wrote: > The branch main has been updated by bz: > > URL: https://cgit.FreeBSD.org/src/commit/?id=5edf24aac1d0978d37d62594f42d87c9f118622b > > commit 5edf24aac1d0978d37d62594f42d87c9f118622b > Author: Bjoern A. Zeeb > AuthorDate: 2026-02-19 23:12:29 +0000 > Commit: Bjoern A. Zeeb > CommitDate: 2026-02-24 22:04:36 +0000 > > ofed: reduce usage of struct dma_attrs *dma_attrs > > ib_verbs.h still uses struct dma_attrs *dma_attrs everywhere. > It is beyond my knowledge when that struct got deprecated upstream but > it is still supported by our LinuxKPI. The problem is that the > functions called with that argument (dma_map_single_attrs, > dma_unmap_single_attrs, dma_map_sg_attrs, dma_unmap_sg_attrs) so far > are #defines in LinuxKPI and drop the last argument (attrs) so it was > never a problem. > > In preparation to pass the attrs to the actual implementation in LinuxKPI, > which has gained support for them, we now pass dma_sttrs->flags which > is the expected unsigned long bit field. > > If anyone has serious interest in updating our ofed implementation they > could look into this some more and remove the usage of struct dma_attrs > entirely. I already have. It's buried in this branch that I still need to get wider testing (and I'm not sure yet I've backported all the things I need): https://github.com/freebsd/freebsd-src/compare/main...bsdjhb:freebsd:ofed_backports Notably, early in the branch are these two commits: https://github.com/freebsd/freebsd-src/commit/a4583c049091d6468593fb04c1fc23c18195666f (cherry-pick of an old Linux commit) and then: https://github.com/freebsd/freebsd-src/commit/788fb6bf0e6f3aa33aaf7dba362c44f1092a3559 -- John Baldwin