From nobody Fri Dec 19 02:40:20 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dXWwm0WyNz6KgwQ; Fri, 19 Dec 2025 02:40:24 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta003.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dXWwl39LGz3Nbw; Fri, 19 Dec 2025 02:40:23 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4001b.ext.cloudfilter.net ([10.228.9.171]) by cmsmtp with ESMTPS id WI3UvySVRAPFJWQPmvI8t0; Fri, 19 Dec 2025 02:40:22 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id WQPlvVYJaVdZGWQPmvohbN; Fri, 19 Dec 2025 02:40:22 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=Sp6dKfO0 c=1 sm=1 tr=0 ts=6944bb16 a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=wP3pNCr1ah4A:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=YxBL1-UpAAAA:8 a=ObADz9b456GCB84EmDMA:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy.cwsent.com [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id DDDA9357; Thu, 18 Dec 2025 18:40:20 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id D5F4221E; Thu, 18 Dec 2025 18:40:20 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: John Baldwin cc: Cy Schubert , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: Re: git: 1b96cdea82c7 - stable/15 - ipfilter: Add missing kenv fetch In-reply-to: <909a8fcd-158a-4b7c-a730-a45516662a83@FreeBSD.org> References: <69449ba5.2386e.1363dce8@gitrepo.freebsd.org> <909a8fcd-158a-4b7c-a730-a45516662a83@FreeBSD.org> Comments: In-reply-to John Baldwin message dated "Thu, 18 Dec 2025 20:42:27 -0500." List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 18 Dec 2025 18:40:20 -0800 Message-Id: <20251219024020.D5F4221E@slippy.cwsent.com> X-CMAE-Envelope: MS4xfF9RQy3x/IBinFlMNKYqBeqYX+gBjLWXPUO7upwLoNT86qRGl2zW9JNOXyE9AQyZ7glYgF7UogKz6VaSu/0KWlFWgjXDl9AYyI6udRH80wlQzF+Lo5zU EAG31O6Al3WUTTA+q6cbqgrMRnl1Uet2FSIj/qYGjCB9S0n10dk8sUFZM1Me0jp7orylNP4wEN3mwBXGMs+0hwIuhknBxFvZayFnDH2jgis3S0GENCLPVm3C BQYZFmDPD8m91VQjX6jZBxBVD4tOljTe27dsz/vcNk6F1hY+zPJFBizVTH67bR4VUAwjXuif7WGfZdwdkbW38YurfagDVgF7hctyeMD1Z7ES5C9ffacOq1MU ujPecKxC X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dXWwl39LGz3Nbw In message <909a8fcd-158a-4b7c-a730-a45516662a83@FreeBSD.org>, John Baldwin wri tes: > On 12/18/25 19:26, Cy Schubert wrote: > > The branch stable/15 has been updated by cy: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=1b96cdea82c77191fb4e777ab63428 > de95f56d3b > > > > commit 1b96cdea82c77191fb4e777ab63428de95f56d3b > > Author: Cy Schubert > > AuthorDate: 2025-12-15 16:21:56 +0000 > > Commit: Cy Schubert > > CommitDate: 2025-12-19 00:26:07 +0000 > > > > ipfilter: Add missing kenv fetch > > > > When a module the environment must be explicitly fetched. > > > > Fixes: d9788eabffa4 > > PR: 291548 > > Noted by: markj > > Reviewed by: markj > > Differential Revision: https://reviews.freebsd.org/D54242 > > MFC after: 3 days > > (cherry picked from commit a6ea80bc917510b5e056cc5a29b62dfd7b39d068) > > This doesn't build on either stable/15 or stable/14: > > /usr/src/sys/netpfil/ipfilter/netinet/ip_fil_freebsd.c:1461:11: error: no mem > ber named 'ipf_jail_allowed' in 'struct ipf_main_softc_s' > 1461 | &softc->ipf_jail_allowed); > | ~~~~~ ^ > /usr/src/sys/sys/kernel.h:334:58: note: expanded from macro 'TUNABLE_INT_FETC > H' > 334 | #define TUNABLE_INT_FETCH(path, var) getenv_int((path), (var)) > | ^~~ > 1 error generated. > *** [ip_fil_freebsd.o] Error code 1 > > -- > John Baldwin I should have merged d9788eabffa4b67fc534685fc3d9b8e3334af196 before this one. I've backed them out in order to apply the prerequisite first. Sorry for the breakage. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e**(i*pi)+1=0