Date: Wed, 13 Jul 2005 19:45:39 +0200 From: "Marius Nuennerich" <marius.nuennerich@gmx.net> To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@FreeBSD.org> Cc: marius.nuennerich@gmx.net Subject: www/83397: Improvement to the GNATS webinterface Message-ID: <1121276739.0@olaf.hackerzberg.local> Resent-Message-ID: <200507131750.j6DHoDnx094084@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 83397 >Category: www >Synopsis: Improvement to the GNATS webinterface >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-www >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Jul 13 17:50:13 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Marius Nuennerich >Release: >Organization: >Environment: >Description: With http://www.freebsd.org/send-pr.html it isn't possible to send most patches in the "fix" textarea, because tabs are replaced with spaces. The attached patch adds the possiblity to upload files, which get attached to the PR in the fix section. Be aware that I have never coded perl before, so it is likely the patch isn't working out of the box. I also had no chance to test and I'm not sure if this is secure! >How-To-Repeat: >Fix: --- patch begins here --- diff -ru www.bak/en/cgi/dosendpr.cgi www/en/cgi/dosendpr.cgi --- www.bak/en/cgi/dosendpr.cgi Wed Jul 13 17:47:04 2005 +++ www/en/cgi/dosendpr.cgi Wed Jul 13 19:25:20 2005 @@ -153,6 +153,14 @@ if ($blackhole_err) { $pr .= "X-REMOTE_ADDR-Is-Open-Proxy: Maybe\n"; } + +{ + use bytes; + if (length($cgi_bin{'patch'}) > 1048576) { + die "patchfile too big!"; + } +} + $pr .= "X-Send-Pr-Version: www-2.3\n\n" . ">Submitter-Id:\t$cgi_data{'submitterid'}\n" . ">Originator:\t$cgi_data{'originator'}\n" . @@ -167,9 +175,10 @@ ">Environment:\t$cgi_data{'environment'}\n" . ">Description:\n$cgi_data{'description'}\n" . ">How-To-Repeat:\n$cgi_data{'howtorepeat'}\n" . - ">Fix:\n$cgi_data{'fix'}\n"; + ">Fix:\n$cgi_data{'fix'}\n" . + "$cgi_data{'patch'}\n"; -# remove any carrage returns that appear in the report. +# remove any carriage returns that appear in the report. $pr =~ s/\r//g; if (open (SUBMIT, "|$submission_program")){ diff -ru www.bak/en/send-pr.sgml www/en/send-pr.sgml --- www.bak/en/send-pr.sgml Wed Jul 13 17:47:09 2005 +++ www/en/send-pr.sgml Wed Jul 13 19:29:18 2005 @@ -38,7 +38,8 @@ the <a href="mailto:&bugbusters;">bugbusters team</a> for submission into the bug tracking system.</p> - <form action="http://www.FreeBSD.org/cgi/dosendpr.cgi" method="post"> + <form action="http://www.FreeBSD.org/cgi/dosendpr.cgi" method="post" + enctype="multipart/form-data"> <input type="hidden" name="submitterid" value="current-users" > <input type="hidden" name="confidential" value="no" > @@ -111,6 +112,9 @@ <label for="fix">Fix to the problem if known</label>: <br> <textarea name="fix" id="fix" rows="6" cols="72"></textarea><br> + + <label for="patch">And/or patchfile</label>: + <input type="file" name="patch" id="patch" maxlength="1048576" accept="text/*"> <label for="code-confirm">Finally, please enter the code from the image below to prove you're not a robot: <br> --- patch ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1121276739.0>