From owner-svn-src-all@freebsd.org Fri Jun 19 10:02:31 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 53F56346985; Fri, 19 Jun 2020 10:02:31 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49pDr708jQz3b25; Fri, 19 Jun 2020 10:02:30 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-yb1-f182.google.com with SMTP id 187so4672477ybq.2; Fri, 19 Jun 2020 03:02:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qNbKhINq7le8E293hfZUjmEgVDu3tAb3ipKIkM55OCQ=; b=mQYwA/cfMpzIF0aX4tz6JEK7wVNG6sQa5YuVBSwa7/UkZzdtLoWGoHlx4W90rpBcQr 9WiLGbSC+Olo7XsqbvZg5EQM3igpDUuuvvuT7fSfKcwpxrZCl3xPrneNMT5882xJAuy1 sUj04CM2JgSaQfih6Or5GZUsJZ6EcXyIbHR9X167iVamhCIjU17XWEoFB0UOJd1qe6Mr NSix1MO5eNShbhN1qX2Msi+jbfAVtwNqkWa9pnzGnj6cxbz0Tee2A20BwC9QsuphJUJ/ tipgNsKt4+SxqVquv/GAFnLfYSrLKbv7DTF1FeFXK2ZexVekDkyYazoMoMhzYCxTUkNJ l5cA== X-Gm-Message-State: AOAM531dix1CQ/7pJeRhBievskHmVUBZiVaR8jBzN8dj9GhBUFj6R1dQ PQvwweUuuP5x0R7YjYlaud4bJx6gTCvosHb+iKsuv+Fc X-Google-Smtp-Source: ABdhPJy5N52+h3hlItL1bHGphg9Xxr2XZFy2OvZjmiEDGY02cI2t9z/tO8ouwSg5LTMNktttKMCvUfc7JwXhKsFejTE= X-Received: by 2002:a25:c646:: with SMTP id k67mr5025009ybf.110.1592560949792; Fri, 19 Jun 2020 03:02:29 -0700 (PDT) MIME-Version: 1.0 References: <202006190332.05J3W53u006443@repo.freebsd.org> In-Reply-To: <202006190332.05J3W53u006443@repo.freebsd.org> From: Li-Wen Hsu Date: Fri, 19 Jun 2020 18:02:18 +0800 Message-ID: Subject: Re: svn commit: r362361 - in head/sys: compat/linuxkpi/common/src vm To: Mark Johnston Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 49pDr708jQz3b25 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2020 10:02:31 -0000 On Fri, Jun 19, 2020 at 11:32 AM Mark Johnston wrote: > > Author: markj > Date: Fri Jun 19 03:32:04 2020 > New Revision: 362361 > URL: https://svnweb.freebsd.org/changeset/base/362361 > > Log: > Add a helper function for validating VA ranges. > > Functions which take untrusted user ranges must validate against the > bounds of the map, and also check for wraparound. Instead of having the > same logic duplicated in a number of places, add a function to check. > > Reviewed by: dougm, kib > Sponsored by: The FreeBSD Foundation > MFC after: 1 week > Differential Revision: https://reviews.freebsd.org/D25328 I'm not sure if it's this one, or 3623630, the following i386 tests all panicked: https://ci.freebsd.org/job/FreeBSD-head-i386-test/9681/console 00:11:31.669 lib/libc/net/protoent_test:protoent -> panic: __rw_wlock_hard: recursing but non-recursive rw vm object @ /usr/src/sys/vm/vm_object.c:869 https://ci.freebsd.org/job/FreeBSD-head-i386-test/9682/console (includes the fix or r362363) 00:27:53.864 bin/pkill/pkill-j_test:main -> Sleeping thread (tid 100115, pid 65628) owns a non-sleepable lock https://ci.freebsd.org/job/FreeBSD-head-i386-test/9683/console 00:02:26.917 bin/pkill/pkill-j_test:main -> Sleeping thread (tid 100152, pid 26582) owns a non-sleepable lock Can you help check these? Thanks, Li-Wen