From nobody Tue Feb 24 05:59:23 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fKn9X6Xthz6T9Kx for ; Tue, 24 Feb 2026 05:59:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fKn9X5Nlqz3VxZ for ; Tue, 24 Feb 2026 05:59:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771912768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JDg+Zt5IaE+HMwb6d/JW3FR4iT4gmQ3CWQRxlzXGjiE=; b=EGagbt9fuVZQOuH4qle4z0386xAEwUkwdJj3rludUO23tY/O/+8RQqMxujE/bmcOoeZ1O1 R8BetAVbodY1OzjgXxKozNqZ4aF1czZ11j+m2caynNixCHGXEGQ98DaL+XlEPELKmS8Oko Z6ruBWHPGrThntZBE5WfbYrahfnCrSH5HlKVH0z9Uj6OUk+TM9+kuxu92jFjkVrLW9w8PO vMQ2i1iBMGl+TyjNJLLJrcJ9vGF+KBhtegEXp2ogdPKHHYhpjHB5o50rd1gKXziBLyWeUE BV1FxsU5gDSm9jNhYGki53ydasQWQEws+6XmIicQ+hk2wC8GBKRfZ/Ee6HeflA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771912768; a=rsa-sha256; cv=none; b=hZyWqY7f1hNkfX+NhGbXnKB5ql1JnMQra9z08nTYK37D1tq8kO9NkxaTJCa5FX3b476Cur lsVuGtEu3DR3d8Unsykwm+OKI3/AUUABMAB8+SV3dCGXSI6jX7WO1m0AIubPWfRAvtWvTf yv5ZFmGn2dgjA/IjsfBdzi4TPEzc/AnUpi5nkweAvotxEqtijf+V5LoDAn7inzv2OmMNh8 lLU7rSe7DbFCjgAQtmiAJfUsAdxSPylxdudGJKTgzEP0PYBe1tMuwtA8U1JF+Fh4u35A2b FZbO5o+g+wuP49Uhn1R7Glg+JVKiqZYycXuNDbDHqLW6EpQQ1iajN9yY8u/D/w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771912768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JDg+Zt5IaE+HMwb6d/JW3FR4iT4gmQ3CWQRxlzXGjiE=; b=sEOfHxkVaMOESPszyHAduuauBnrl42hhh5hGwxru8g7OGxQISIOz7u8NFkmP1Lt5XCFglM RmqNhOSwOk86EeTpgTmvJdnQT3fICY6xnOyaXPC3KLRPVZiU4iAM3eJDTcQZnWapIdlpdn XnHK0Zmnd8KwLx49WnjZsYu8JJpEvK1Z65hsWTBwgnVRBLmlD8j26bjYe4zO9aeqg/FqBK c9mfbzBwVWfKw1KhZhSLxrXa17IAwaJd/TFerS3402wAi0M8L3KAMrJwg3vPUSSHmjvRpD bgVYzpVznqSmhAHP4J7zDnVeuXQHZOn6JYIwVUNf1cDggk1G14419x+TiJ8aTw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fKn9X4xsvz12hj for ; Tue, 24 Feb 2026 05:59:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3f49e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 24 Feb 2026 05:59:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kyle Evans Subject: git: 686280c0fdc4 - main - libjail: avoid a double-free in the MAC label bits List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 686280c0fdc4807676c3e8b896a1816ce62d4457 Auto-Submitted: auto-generated Date: Tue, 24 Feb 2026 05:59:23 +0000 Message-Id: <699d3e3b.3f49e.3106aad9@gitrepo.freebsd.org> The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=686280c0fdc4807676c3e8b896a1816ce62d4457 commit 686280c0fdc4807676c3e8b896a1816ce62d4457 Author: Kyle Evans AuthorDate: 2026-02-24 05:55:12 +0000 Commit: Kyle Evans CommitDate: 2026-02-24 05:58:45 +0000 libjail: avoid a double-free in the MAC label bits As written, we'll repeatedly jps_free() the first element, which is obviously bogus. Fix it to index appropriately. Fixes: db3b39f063d9f ("libjail: extend struct handlers [...]") --- lib/libjail/jail.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libjail/jail.c b/lib/libjail/jail.c index baabeb4afed9..95ba336b62ce 100644 --- a/lib/libjail/jail.c +++ b/lib/libjail/jail.c @@ -978,7 +978,7 @@ jailparam_free(struct jailparam *jp, unsigned njp) for (j = 0; j < njp; j++) { free(jp[j].jp_name); if (!(jp[j].jp_flags & JP_RAWVALUE)) { - jps_free(jp); + jps_free(&jp[j]); free(jp[j].jp_value); } }