From owner-freebsd-ports Mon Aug 24 00:30:42 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id AAA08882 for freebsd-ports-outgoing; Mon, 24 Aug 1998 00:30:42 -0700 (PDT) (envelope-from owner-freebsd-ports@FreeBSD.ORG) Received: from localhost.my.domain (ppp6484.on.bellglobal.com [206.172.208.76]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA08827; Mon, 24 Aug 1998 00:30:29 -0700 (PDT) (envelope-from hoek@FreeBSD.ORG) Received: from localhost (tim@localhost) by localhost.my.domain (8.8.8/8.8.8) with SMTP id DAA04046; Mon, 24 Aug 1998 03:29:24 -0400 (EDT) (envelope-from ac199@hwcn.org) X-Authentication-Warning: localhost.my.domain: tim owned process doing -bs Date: Mon, 24 Aug 1998 03:29:24 -0400 (EDT) From: Tim Vanderhoek X-Sender: tim@localhost Reply-To: ac199@hwcn.org To: Satoshi Asami cc: ac199@hwcn.org, vanilla@FreeBSD.ORG, ports@FreeBSD.ORG Subject: Re: manpages (Re: cvs commit: ports/devel/p5-Term-Query p5-Term-Query-2.0.tgz) In-Reply-To: <199808240608.XAA02385@silvia.hip.berkeley.edu> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Sun, 23 Aug 1998, Satoshi Asami wrote: > === > .for sect in 1 2 3 4 5 6 7 8 9 > .if exists(${PKGDIR}/MAN${sect}) > MAN${sect}+= ${CAT} ${PKGDIR}/MAN${sect} > .endif > .endfor > === It sure seems like a good idea to me. My one worry is that this would make more work for Steve, vanilla, mph, or one of the committers who dedicate countless hours to testing and closing the various PRs that submit updates to ports...? Other than that, it sure would make some Makefiles look a lot nicer... The other possibility is just to let Makefiles use a ``.include "pkg/MEN"''. [Of course, a guideline such as "don't use this for less than XX manpages" should be made.] > +# NO_WRKDIR - There's no work directory at all; port does this someplace > +# else. Obviously still there... > ARCH!= uname -m > @@ -352,8 +454,23 @@ > PKGDIR?= ${.CURDIR}/pkg [Many more lines elided] Somehow you've changed what was originally a simple change into something pretty large... :) Since so much is changing anyways... Is it worthwhile changing a few non-absolute paths to absolute ones? I'm not sure what the original reason for using absolute paths was, but if it was good... :) My cursory scroll-through finds naked pkg_delete, expr, and of course, many many [. I assume the last one was intentional due to the fact that even using the short variable form "$[" doubles its length. :) There's also a naked ldconfig on line ~1751. [Hehe. I'm tempted to suggest an INSTALLS_SHLIBS variable, now, but that probably should wait untill after E-day, at least :-] -- This .sig is not innovative, witty, or profund. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message