From owner-svn-ports-head@FreeBSD.ORG  Thu May 14 16:00:37 2015
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4AC19F26;
 Thu, 14 May 2015 16:00:37 +0000 (UTC)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "abg.ninja", Issuer "Gandi Standard SSL CA 2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A2F841E4B;
 Thu, 14 May 2015 16:00:36 +0000 (UTC)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id 06895d9e;
 TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO;
 Thu, 14 May 2015 10:00:34 -0600 (MDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\))
Subject: Re: svn commit: r386285 - head/security/keychain
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <CACM2dAaFL6F-=mbfODTRrR83L+GeLfxzcM16DoroP1shmP6NHQ@mail.gmail.com>
Date: Thu, 14 May 2015 10:00:32 -0600
Cc: Bryan Drewery <bdrewery@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <082DB80D-6385-4F4F-8A86-2DB4561E39E8@adamw.org>
References: <201505140101.t4E11r9T031351@svn.freebsd.org>
 <08F806A7-3CD9-417A-BA4E-AF739E83B6A8@adamw.org>
 <CACM2dAaFL6F-=mbfODTRrR83L+GeLfxzcM16DoroP1shmP6NHQ@mail.gmail.com>
To: "Philip M. Gollucci" <pgollucci@p6m7g8.com>
X-Mailer: Apple Mail (2.2098)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 May 2015 16:00:37 -0000

> On 13 May, 2015, at 21:20, Philip M. Gollucci <pgollucci@p6m7g8.com> =
wrote:
>=20
> Then it needs an option not an if exists()

Bryan, can you please consider reverting it, or giving me approval to =
revert it? It may fix the case when the port is built in poudriere =
without sshd in base, but it is a regression for everybody else.

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org



>=20
> On Wed, May 13, 2015 at 10:37 PM, Adam Weinberger <adamw@adamw.org> =
wrote:
> > On 13 May, 2015, at 19:01, Bryan Drewery <bdrewery@FreeBSD.org> =
wrote:
> >
> > Author: bdrewery
> > Date: Thu May 14 01:01:52 2015
> > New Revision: 386285
> > URL: https://svnweb.freebsd.org/changeset/ports/386285
> >
> > Log:
> >  Don't use exists() for the ssh dependency. The RUN_DEPENDS line =
already
> >  handles checking if these files exist. Removing this fixes =
poudriere
> >  already rebuilding this port when there is no base sshd and only a =
port
> >  version.
>=20
> Now keychain unconditionally brings in openssh-portable, which it =
didn't before.
>=20
> # Adam
>=20
>=20
> --
> Adam Weinberger
> adamw@adamw.org
> http://www.adamw.org
>=20
>=20
>=20
>=20
>=20
> --=20
> =
--------------------------------------------------------------------------=
-------
> Curb: Your ride is here
> 4096R/D21D2752 ECDF B597 B54B 7F92 753E  E0EA F699 A450 D21D 2752
> Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
> Member,                           Apache Software Foundation
> Committer,                        FreeBSD Foundation
> Consultant,                       P6M7G8 Inc.
> Sr. Director IT Operations,       Curb
>=20
> What doesn't kill us can only make us stronger;
> Except it almost kills you.