Date: Sun, 13 May 2018 21:44:17 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 228227] ports-mgmt/portlint: overeager "typically when you specify magic site you do not need anything else" Message-ID: <bug-228227-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D228227 Bug ID: 228227 Summary: ports-mgmt/portlint: overeager "typically when you specify magic site you do not need anything else" Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: marcus@FreeBSD.org Reporter: gerald@FreeBSD.org Flags: maintainer-feedback?(marcus@FreeBSD.org) Assignee: marcus@FreeBSD.org This warning added in response to PR 225503 has proved useful in helping me simplify gcc7, gcc6, and a couple of older GCC-related ports. It is, however, overeager for several other cases, such as % cd $PORTSDIR/lang/gcc8-devel % portlint -C WARN: Makefile: typically when you specify magic site GCC you do not need anything else as releases/gcc-8-20180511 is assumed This port has CATEGORIES=3D lang MASTER_SITES=3D GCC/snapshots/${DIST_VERSION} whereas wh in Mk/bsd.sites.mk has GCC:releases/${DISTNAME}=20 Would avoiding the warning when the first directory component of MASTER_SITES is *not* part of what MASTER_SITES_ABBREVS be a good heuristics? (In this case that would be "snapshots" which is not part of "releases/${DISTNAME}".) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-228227-7788>