From owner-svn-src-all@freebsd.org Sun Feb 10 08:38:43 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 01F7114E5013; Sun, 10 Feb 2019 08:38:43 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it1-f195.google.com (mail-it1-f195.google.com [209.85.166.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A50976CBCA; Sun, 10 Feb 2019 08:38:41 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it1-f195.google.com with SMTP id r6so19287189itk.0; Sun, 10 Feb 2019 00:38:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=ocw3MvI1DTBXGQpK8O3DFkbY7WTUDSPscMaNKWIOFyE=; b=fmrV4Qcs/jcfbhZjGF8p2/A7HmOzgWIAQ3j4KWXZ9QlMdlAELq23pThxcgpEN1NRlh i2TBxB5B65B+cnUWgcZK2eTXiHQycR6mvvYZAmYwC6FBWHpWUMt0burShPgclD/Xc0NR VzNMcu4omWpJfH5TRGyGX+zP3bnSYf9yCynId75t01qwsqV49+XesS0SJvkOJcFNKeuW kTV/l3SVmHf9PF4wzotadNjkr2b3mQjrbffdLYEVXEITvbABstfqvxgx+Q0BFqcTbFfc EigLmF3CTRBbR7ES7kYlMmQXahzxhBe+Kx3MMJIT3EScoBiOxWK8qQey7ZqB6sSeibvs +msw== X-Gm-Message-State: AHQUAuYc7SVbIrpd6h3H4RThFJMMaP6Ip9Am+GQcI6J2yxGCtRzbNltN 3zjv7BMDIX2J54dLS9LroHvyyqA/ X-Google-Smtp-Source: AHgI3IbkfOKiH97hKGLHPv986mwaBYdEyKve3URzqoeJdNo/LIbRijdD2ArK4X+CHOXRAl72n5NJMQ== X-Received: by 2002:a6b:f70a:: with SMTP id k10mr2213313iog.68.1549787915271; Sun, 10 Feb 2019 00:38:35 -0800 (PST) Received: from mail-it1-f172.google.com (mail-it1-f172.google.com. [209.85.166.172]) by smtp.gmail.com with ESMTPSA id z1sm2924144ioi.77.2019.02.10.00.38.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Feb 2019 00:38:34 -0800 (PST) Received: by mail-it1-f172.google.com with SMTP id a6so19176249itl.4; Sun, 10 Feb 2019 00:38:34 -0800 (PST) X-Received: by 2002:a02:4c4a:: with SMTP id a71mr2421410jab.104.1549787914779; Sun, 10 Feb 2019 00:38:34 -0800 (PST) MIME-Version: 1.0 References: <201902041655.x14GtOIr046072@repo.freebsd.org> <6436189F-037C-4AB0-A59C-BE68A781FB30@fh-muenster.de> In-Reply-To: <6436189F-037C-4AB0-A59C-BE68A781FB30@fh-muenster.de> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sun, 10 Feb 2019 00:38:24 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r343746 - head/sys/conf To: Michael Tuexen Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A50976CBCA X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of csecem@gmail.com designates 209.85.166.195 as permitted sender) smtp.mailfrom=csecem@gmail.com X-Spamd-Result: default: False [-3.81 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[cem@freebsd.org]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.64)[-0.639,0]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[195.166.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.16)[ipnet: 209.85.128.0/17(-3.78), asn: 15169(-1.95), country: US(-0.07)]; RWL_MAILSPIKE_POSSIBLE(0.00)[195.166.85.209.rep.mailspike.net : 127.0.0.17] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Feb 2019 08:38:43 -0000 Hi Michael, I don't know. You can 'pkg install amd64-xtoolchain-gcc' and 'make buildkernel KERNCONF=3DGENERIC CROSS_TOOLCHAIN=3Damd64-gcc' if you're interested in trying it. (I'm not sure enabling coverage globally in GENERIC is appropriate even if it did not break boot =E2=80=94 it's usually expensive, and while GENERIC is already slow, that doesn't mean we can just make it 10x slower.) Best, Conrad On Sun, Feb 10, 2019 at 12:03 AM Michael Tuexen wro= te: > > > On 10. Feb 2019, at 08:50, Conrad Meyer wrote: > > > > Hi Andrew, > > > > This makes it compile, but instead of a build failure the kernel is > > broken hard at runtime in early boot with GCC < 8.1. E.g., > > amd64-xtoolchain-gcc standard cross-toolchain is still on GCC 6.4.0. > > > > HEAD GENERIC has been broken in one form or another for xtoolchain GCC > > since r343713 (Feb 3), so I'm going to go ahead and turn this option > > off in GENERIC. Feel free to reenable when you've tested that it > > works. > Hi Conrad, > > does https://reviews.freebsd.org/D19135 fix the issue you are observing? > > Best regards > Michael > > > > Best, > > Conrad > > > > On Mon, Feb 4, 2019 at 8:55 AM Andrew Turner wrote= : > >> > >> Author: andrew > >> Date: Mon Feb 4 16:55:24 2019 > >> New Revision: 343746 > >> URL: https://svnweb.freebsd.org/changeset/base/343746 > >> > >> Log: > >> Only enable trace-cmp on Clang and modern GCC. > >> > >> It's was only added to GCC 8.1 so don't try to enable it for earlier > >> releases. > >> > >> Reported by: lwhsu > >> Sponsored by: DARPA, AFRL > >> > >> Modified: > >> head/sys/conf/files > >> head/sys/conf/kern.pre.mk > >> > >> Modified: head/sys/conf/files > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >> --- head/sys/conf/files Mon Feb 4 16:13:41 2019 (r343745) > >> +++ head/sys/conf/files Mon Feb 4 16:55:24 2019 (r343746) > >> @@ -3808,7 +3808,7 @@ kern/kern_idle.c standard > >> kern/kern_intr.c standard > >> kern/kern_jail.c standard > >> kern/kern_kcov.c optional kcov \ > >> - compile-with "${NORMAL_C} -fno-sanitize-coverage=3D= trace-pc,trace-cmp" > >> + compile-with "${NORMAL_C} -fno-sanitize=3Dall" > >> kern/kern_khelp.c standard > >> kern/kern_kthread.c standard > >> kern/kern_ktr.c optional ktr > >> > >> Modified: head/sys/conf/kern.pre.mk > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >> --- head/sys/conf/kern.pre.mk Mon Feb 4 16:13:41 2019 (r3437= 45) > >> +++ head/sys/conf/kern.pre.mk Mon Feb 4 16:55:24 2019 (r3437= 46) > >> @@ -120,7 +120,12 @@ SAN_CFLAGS+=3D -fsanitize=3Dundefined > >> > >> COVERAGE_ENABLED!=3D grep COVERAGE opt_global.h || true ; echo > >> .if !empty(COVERAGE_ENABLED) > >> +.if ${COMPILER_TYPE} =3D=3D "clang" || \ > >> + (${COMPILER_TYPE} =3D=3D "gcc" && ${COMPILER_VERSION} >=3D 80100) > >> SAN_CFLAGS+=3D -fsanitize-coverage=3Dtrace-pc,trace-cmp > >> +.else > >> +SAN_CFLAGS+=3D -fsanitize-coverage=3Dtrace-pc > >> +.endif > >> .endif > >> > >> CFLAGS+=3D ${SAN_CFLAGS} > >> > > >