From owner-freebsd-current@FreeBSD.ORG Wed Mar 31 14:48:07 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 504FA106566B for ; Wed, 31 Mar 2010 14:48:07 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 8EE498FC13 for ; Wed, 31 Mar 2010 14:48:06 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id RAA21360; Wed, 31 Mar 2010 17:48:02 +0300 (EEST) (envelope-from avg@freebsd.org) Message-ID: <4BB360A1.7020309@freebsd.org> Date: Wed, 31 Mar 2010 17:48:01 +0300 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.24 (X11/20100319) MIME-Version: 1.0 To: Fabian Keil References: <3a142e751003190508x6a06868ene2e8fd9ddd977f66@mail.gmail.com> <3a142e751003191021p141af009m6acf7d160c890cbb@mail.gmail.com> <20100319191133.46fe271c@r500.local> <3a142e751003191126j331e525fwb9e5573bbf6f7d58@mail.gmail.com> <4BAA30CB.1070707@icyb.net.ua> <20100328172537.501ed3d1@r500.local> <4BB0A053.9060007@freebsd.org> <20100329222920.5eef6395@r500.local> <4BB111D4.8060809@freebsd.org> <20100330173637.202b4b1e@r500.local> <4BB21BBA.7030407@freebsd.org> In-Reply-To: <4BB21BBA.7030407@freebsd.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Kostik Belousov , freebsd-current@freebsd.org, Bruce Evans Subject: Re: newfs_msdos and DVD-RAM X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2010 14:48:07 -0000 on 30/03/2010 18:41 Andriy Gapon said the following: > on 30/03/2010 18:36 Fabian Keil said the following: >> Andriy Gapon wrote: >> >>> on 29/03/2010 23:29 Fabian Keil said the following: >>>> Andriy Gapon wrote: >>>>> Thus, clearly, it is a fault of a tool that formatted the media for FAT. >>>>> It should have picked correct values, or rejected incorrect values if >>>>> those were provided as overrides via command line options. >>>> The kernel still shouldn't panic, though. >>> A quick reply to this point only - yes, I completely agree. >>> But remember that the panic happened only after the sources were modified :) >> It wasn't clear from my message, but I was mainly referring to the >> division-by-zero panic mentioned at the beginning of the thread, >> for which I posted a work-around in <20100319191133.46fe271c@r500.local>. > > Oh, yes, right. To clarify - I already forgot that the original problem was division by zero panic and for some reason thought that it was EINVAL. Anyways, here is a patch that I would use. Unfortunately, ENOTIME to understand newfs_msdos code and fix it too, --- a/sys/fs/msdosfs/msdosfs_vfsops.c +++ b/sys/fs/msdosfs/msdosfs_vfsops.c @@ -580,6 +580,7 @@ mountmsdosfs(struct vnode *devvp, struct mount *mp) || (pmp->pm_BytesPerSec & (pmp->pm_BytesPerSec - 1)) || (pmp->pm_HugeSectors == 0) || (pmp->pm_FATsecs == 0) + || (SecPerClust * pmp->pm_BlkPerSec > MAXBSIZE / DEV_BSIZE) ) { error = EINVAL; goto error_exit; -- Andriy Gapon