From owner-svn-ports-all@FreeBSD.ORG Sun Sep 2 18:12:09 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C268D1065673; Sun, 2 Sep 2012 18:12:09 +0000 (UTC) (envelope-from villa.alberto@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id B9ECD8FC0A; Sun, 2 Sep 2012 18:12:08 +0000 (UTC) Received: by bkcje9 with SMTP id je9so2257975bkc.13 for ; Sun, 02 Sep 2012 11:12:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=FxQhyIr35qdwESgopcZfZ08YGK3Tm7vcWwqzS3rgP+Y=; b=EfT4LNo4euCKo3ANOVkkt1YPMFwLAv0KMgmtX4NOwEIJA9RXAWXUxvcrEmCDVzaap5 nflMEe7r53RkEzb5v0yzU9yjK181YTA7UqTJC0hzyYLbs7J7eHHtxirtwpYQdgMfoo0x DslASZSmCqePbMrJ8/zJz8hTJ0DcXAWy3HJG6ldgl+IkQt1obALGl9mIc6oF6a/ZEuci azvQvO/CtPBqRBQ+naDYCXcSQwGwJzF/IcvC/KrDYFCOTXVcy9SONUg6jACrZM0ohY2H 5cuhfPsZJHiYWs62lRr9XBBER46ZW6P1PHyRIQtwIvYiUyrY0l3u6GgmcQv6pbpmyF70 XwDw== Received: by 10.204.129.23 with SMTP id m23mr6149225bks.28.1346609527389; Sun, 02 Sep 2012 11:12:07 -0700 (PDT) MIME-Version: 1.0 Sender: villa.alberto@gmail.com Received: by 10.204.147.217 with HTTP; Sun, 2 Sep 2012 11:11:47 -0700 (PDT) In-Reply-To: <20120902174533.GE10884@FreeBSD.org> References: <201209010946.q819kRxc085704@svn.freebsd.org> <20120902174533.GE10884@FreeBSD.org> From: Alberto Villa Date: Sun, 2 Sep 2012 20:11:47 +0200 X-Google-Sender-Auth: ezgOzEwmxY2ETs24CutdeL7MrLs Message-ID: To: Alexey Dokuchaev Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r303465 - head/multimedia/mlt X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Sep 2012 18:12:09 -0000 On Sun, Sep 2, 2012 at 7:45 PM, Alexey Dokuchaev wrote: > Any special reason to install copies of standard licenses? I didn't remember that Templates/Licences/ existed, that's the only reason. :) I'll remove them on the next update (if I verify that they are completely standard). > It seems that we commonly do not put space after GTK+ (e.g. GTK+1, GTK+2). And that's wrong, like for Qt 4 or KDE 4. That's why I fixed it in bsd.options.desc.mk. I'm open to discussion on this. > You could have saved a line in CONFIGURE_ARGS here since both options would > fit on one line. \ makes sense for long argument list to improve > readability and "svn blame" output, but not in this particular case. Right, I'll change it. > You also could've dropped shlib version number here (and below), unless > particular ABI is indeed required (in this case, it should been mentioned > in commit log or Makefile comment). I always find this an interesting point, but never managed to read anything near to "official" about it, so I always left it as it was at the beginning. Is there some thread discussing it? Also, some time ago I had a talk with bapt@ about pkgng and alternate dependencies, and my conclusions were that specifying ABI would have paid in the long term. But that was pure fantasy, and lots of things could be said against this. > These seem unnecessary and just shadow whom to "svn blame". I just wanted to tidy it up a bit (I tend to be quite obsessive sometimes :), but you're right, I'll pay more attention. > Also, perhaps > global modifier is superfluous here (also below). It is, if I remember correctly, but I think I added it in the very beginning because it was my first port and I had no real experience. On the next update I'll check it, but I always felt like it wasn't a problem to think about. Thank for reviewing (really). ;) -- Alberto Villa, FreeBSD committer http://people.FreeBSD.org/~avilla