Date: Sun, 2 Sep 2012 20:11:47 +0200 From: Alberto Villa <avilla@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r303465 - head/multimedia/mlt Message-ID: <CAJp7RHb0PRu3EfH7T9S0vF1%2BcuVu-2sP7A%2BwoX-RAVn=C-KPSw@mail.gmail.com> In-Reply-To: <20120902174533.GE10884@FreeBSD.org> References: <201209010946.q819kRxc085704@svn.freebsd.org> <20120902174533.GE10884@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Sep 2, 2012 at 7:45 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote: > Any special reason to install copies of standard licenses? I didn't remember that Templates/Licences/ existed, that's the only reason. :) I'll remove them on the next update (if I verify that they are completely standard). > It seems that we commonly do not put space after GTK+ (e.g. GTK+1, GTK+2). And that's wrong, like for Qt 4 or KDE 4. That's why I fixed it in bsd.options.desc.mk. I'm open to discussion on this. > You could have saved a line in CONFIGURE_ARGS here since both options would > fit on one line. \ makes sense for long argument list to improve > readability and "svn blame" output, but not in this particular case. Right, I'll change it. > You also could've dropped shlib version number here (and below), unless > particular ABI is indeed required (in this case, it should been mentioned > in commit log or Makefile comment). I always find this an interesting point, but never managed to read anything near to "official" about it, so I always left it as it was at the beginning. Is there some thread discussing it? Also, some time ago I had a talk with bapt@ about pkgng and alternate dependencies, and my conclusions were that specifying ABI would have paid in the long term. But that was pure fantasy, and lots of things could be said against this. > These seem unnecessary and just shadow whom to "svn blame". I just wanted to tidy it up a bit (I tend to be quite obsessive sometimes :), but you're right, I'll pay more attention. > Also, perhaps > global modifier is superfluous here (also below). It is, if I remember correctly, but I think I added it in the very beginning because it was my first port and I had no real experience. On the next update I'll check it, but I always felt like it wasn't a problem to think about. Thank for reviewing (really). ;) -- Alberto Villa, FreeBSD committer <avilla@FreeBSD.org> http://people.FreeBSD.org/~avilla
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJp7RHb0PRu3EfH7T9S0vF1%2BcuVu-2sP7A%2BwoX-RAVn=C-KPSw>